From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752223AbcGROwK (ORCPT ); Mon, 18 Jul 2016 10:52:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59592 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbcGROwH (ORCPT ); Mon, 18 Jul 2016 10:52:07 -0400 Date: Mon, 18 Jul 2016 16:52:01 +0200 From: Benjamin Tissoires To: Andrew Duggan Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Linus Walleij , Jiri Kosina , Vincent Huang , Nick Dyer , Chris Healy Subject: Re: [PATCH v3 8/8] Input: synaptics-rmi4: Use the RMI_F11_REL_BYTES define in rmi_f11_rel_pos_report Message-ID: <20160718145201.GN4663@mail.corp.redhat.com> References: <1468476613-8293-1-git-send-email-aduggan@synaptics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1468476613-8293-1-git-send-email-aduggan@synaptics.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 18 Jul 2016 14:52:07 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jul 13 2016 or thereabouts, Andrew Duggan wrote: > The size of relative data in F11 is already defined by RMI_F11_REL_BYTES. > Use the define in rmi_f11_rel_pos_report() to be consistent. > > Signed-off-by: Andrew Duggan > Reviewed-by: Nick Dyer Reviewed-by: Benjamin Tissoires > --- > This is the same as the v2 version. > > drivers/input/rmi4/rmi_f11.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c > index 3fda75b..cce82a1 100644 > --- a/drivers/input/rmi4/rmi_f11.c > +++ b/drivers/input/rmi4/rmi_f11.c > @@ -530,8 +530,8 @@ static void rmi_f11_rel_pos_report(struct f11_data *f11, u8 n_finger) > struct f11_2d_data *data = &f11->data; > s8 x, y; > > - x = data->rel_pos[n_finger * 2]; > - y = data->rel_pos[n_finger * 2 + 1]; > + x = data->rel_pos[n_finger * RMI_F11_REL_BYTES]; > + y = data->rel_pos[n_finger * RMI_F11_REL_BYTES + 1]; > > rmi_2d_sensor_rel_report(sensor, x, y); > } > -- > 2.5.0 >