From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Andrey Pronin <apronin@chromium.org>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
groeck@chromium.org, smbarber@chromium.org,
dianders@chromium.org
Subject: Re: [PATCH 1/2] tpm_tis_core: add optional max xfer size check
Date: Mon, 18 Jul 2016 21:53:27 +0300 [thread overview]
Message-ID: <20160718185327.GJ31463@intel.com> (raw)
In-Reply-To: <20160715031351.GD9347@obsidianresearch.com>
On Thu, Jul 14, 2016 at 09:13:51PM -0600, Jason Gunthorpe wrote:
> On Thu, Jul 14, 2016 at 06:39:04PM -0700, Andrey Pronin wrote:
>
> > +static inline u16 tpm_tis_max_xfer_size(struct tpm_tis_data *data)
> > +{
> > + return data->phy_ops->max_xfer_size;
> > +}
> > +
> > +static inline bool tpm_tis_burstcnt_is_valid(struct tpm_tis_data *data,
> > + u16 burstcnt)
> > +{
> > + return (tpm_tis_max_xfer_size(data) == 0)
> > + || (burstcnt <= tpm_tis_max_xfer_size(data));
> > +}
>
> We don't need these accessors, just open code it in the one call
> site. That is more clear as the ==0 case is important to understand
> that the flow is correct.
+1 They add only indirection here with no value.
> BTW, I dodn't think || as the start of a line was cannonical kernel
> style.. Did checkpatch accept that?
>
> Jason
/Jarkko
next prev parent reply other threads:[~2016-07-18 18:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 1:39 [PATCH 0/2] tpm: add optional max xfer size check Andrey Pronin
2016-07-15 1:39 ` [PATCH 1/2] tpm_tis_core: " Andrey Pronin
2016-07-15 3:13 ` Jason Gunthorpe
2016-07-15 3:25 ` Andrey Pronin
2016-07-15 3:48 ` Guenter Roeck
2016-07-18 18:53 ` Jarkko Sakkinen [this message]
2016-07-15 1:39 ` [PATCH 2/2] tpm_tis_spi: add max xfer size Andrey Pronin
2016-07-20 2:34 ` [PATCH v2 0/2] tpm: add optional max xfer size check Andrey Pronin
2016-07-20 2:34 ` [PATCH v2 1/2] tpm_tis_core: " Andrey Pronin
2016-07-20 2:34 ` [PATCH v2 2/2] tpm_tis_spi: add max xfer size Andrey Pronin
2016-07-20 15:10 ` [PATCH v2 0/2] tpm: add optional max xfer size check Jarkko Sakkinen
2016-07-28 3:49 ` [PATCH v3 " Andrey Pronin
2016-07-28 3:49 ` [PATCH v3 1/2] tpm_tis_core: " Andrey Pronin
2016-07-28 22:52 ` Dmitry Torokhov
2016-08-09 8:14 ` Jarkko Sakkinen
2016-07-28 3:49 ` [PATCH v3 2/2] tpm_tis_spi: add max xfer size Andrey Pronin
2016-07-28 22:53 ` Dmitry Torokhov
2016-08-09 8:14 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718185327.GJ31463@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=apronin@chromium.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=smbarber@chromium.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).