From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbcGRTRh (ORCPT ); Mon, 18 Jul 2016 15:17:37 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33651 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbcGRTRe (ORCPT ); Mon, 18 Jul 2016 15:17:34 -0400 Date: Mon, 18 Jul 2016 12:17:31 -0700 From: Andrey Pronin To: Jarkko Sakkinen Cc: Peter Huewe , Marcel Selhorst , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, groeck@chromium.org, smbarber@chromium.org, dianders@chromium.org Subject: Re: [PATCH 2/2] tpm: support driver-specific sysfs attrs in tpm_tis_core Message-ID: <20160718191731.GA1706@apronin> References: <1468547496-16215-1-git-send-email-apronin@chromium.org> <1468547496-16215-3-git-send-email-apronin@chromium.org> <20160718191141.GO31463@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160718191141.GO31463@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2016 at 10:11:41PM +0300, Jarkko Sakkinen wrote: > On Thu, Jul 14, 2016 at 06:51:36PM -0700, Andrey Pronin wrote: > > Add attr_group to phy_ops that a driver relying on tpm_tis_core_init > > can set to have its specific attributes registered in sysfs. > > > > Signed-off-by: Andrey Pronin > > --- > > drivers/char/tpm/tpm-sysfs.c | 1 - > > drivers/char/tpm/tpm.h | 8 +++++++- > > drivers/char/tpm/tpm_tis_core.c | 3 +++ > > drivers/char/tpm/tpm_tis_core.h | 1 + > > 4 files changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm-sysfs.c > > index 95ce90d..22c9874 100644 > > --- a/drivers/char/tpm/tpm-sysfs.c > > +++ b/drivers/char/tpm/tpm-sysfs.c > > @@ -304,7 +304,6 @@ void tpm_sysfs_add_device(struct tpm_chip *chip) > > * is called before ops is null'd and the sysfs core synchronizes this > > * removal so that no callbacks are running or can run again > > */ > > - WARN_ON(chip->groups_cnt != 0); > > You should explain this in a commit message if you want to remove it. > > In general, this make user space API vendor specific, which is > unacceptable. > > /Jarkko > I will drop the vendor-specific part of the patchset and just submit tpm2-specific sysfs attributes in the next rev. WARN_ON will not be removed.