From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751985AbcGRTWi (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jul 2016 15:22:38 -0400
Received: from pmta2.delivery5.ore.mailhop.org ([54.186.218.12]:12530 "EHLO
	pmta2.delivery5.ore.mailhop.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751254AbcGRTWf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jul 2016 15:22:35 -0400
X-MHO-User: 1dd19a16-4d1d-11e6-8929-8ded99d5e9d7
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 74.99.65.212
X-Mail-Handler: DuoCircle Outbound SMTP
X-DKIM: OpenDKIM Filter v2.6.8 io 5CFF980050
Date: Mon, 18 Jul 2016 19:22:31 +0000
From: Jason Cooper <jason@lakedaemon.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Gregory CLEMENT <gregory.clement@free-electrons.com>,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        "David S. Miller" <davem@davemloft.net>,
        Richard Cochran <rcochran@linutronix.de>, linux-kernel@vger.kernel.org,
        Anna-Maria Gleixner <anna-maria@linutronix.de>
Subject: Re: [PATCH] irqchip: armada: avoid unused function warnings
Message-ID: <20160718192231.GG5814@io.lakedaemon.net>
References: <20160718160335.3134412-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160718160335.3134412-1-arnd@arndb.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+ Anna-Maria

Hey Arnd,

On Mon, Jul 18, 2016 at 06:03:21PM +0200, Arnd Bergmann wrote:
> When building with CONFIG_SMP disabled, we get some new harmless warnings:
> 
> drivers/irqchip/irq-armada-370-xp.c:356:12: error: 'mpic_cascaded_starting_cpu' defined but not used [-Werror=unused-function]
>  static int mpic_cascaded_starting_cpu(unsigned int cpu)
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/irqchip/irq-armada-370-xp.c:349:12: error: 'armada_xp_mpic_starting_cpu' defined but not used [-Werror=unused-function]
>  static int armada_xp_mpic_starting_cpu(unsigned int cpu)
> 
> This moves the unused functions into the #ifdef, as they previously were.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: cb5ff2d245c1 ("irqchip/armada-370-xp: Convert to hotplug state machine")
> ---
>  drivers/irqchip/irq-armada-370-xp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Jason Cooper <jason@lakedaemon.net>

Anna-Maria, can you make sure this gets pulled in with the cpuhp
changes?  afaict, cb5ff2d245c1 is only in the tip/WIP.hotplug and
tip/master.

thx,

Jason.