From: Tejun Heo <tj@kernel.org>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/radeon: Remove deprecated create_singlethread_workqueue
Date: Mon, 18 Jul 2016 20:48:21 -0400 [thread overview]
Message-ID: <20160719004821.GD3078@mtj.duckdns.org> (raw)
In-Reply-To: <20160716113044.GA18061@Karyakshetra>
On Sat, Jul 16, 2016 at 05:00:44PM +0530, Bhaktipriya Shridhar wrote:
>
> alloc_workqueue replaces deprecated create_singlethread_workqueue().
>
> Each hardware CRTC has a single flip work queue.
> When a radeon_flip_work_func item is queued, it needs to be executed
> ASAP because even a slight delay may cause the flip to be delayed by
> one refresh cycle.
>
> Hence, a dedicated workqueue with WQ_HIGHPRI set, has been used here
> since a delay can cause the outcome to miss the refresh cycle.
>
> Since there are only a fixed number of work items, explicit concurrency
> limit is unnecessary here.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2016-07-19 0:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-02 11:03 [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar
2016-07-02 13:46 ` Tejun Heo
2016-07-04 3:58 ` Michel Dänzer
2016-07-05 21:06 ` Tejun Heo
2016-07-06 3:12 ` Michel Dänzer
2016-07-06 13:45 ` Tejun Heo
2016-07-07 3:32 ` Michel Dänzer
2016-07-07 7:43 ` Christian König
2016-07-08 5:52 ` Michel Dänzer
2016-07-12 17:52 ` Tejun Heo
2016-07-16 11:30 ` [PATCH v2] " Bhaktipriya Shridhar
2016-07-18 13:21 ` Christian König
2016-07-19 0:48 ` Tejun Heo [this message]
2016-07-28 16:14 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719004821.GD3078@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=bhaktipriya96@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).