From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-api@vger.kernel.org
Subject: Re: [PATCH 3/3] f2fs: support clone_file_range
Date: Mon, 18 Jul 2016 21:48:20 -0700 [thread overview]
Message-ID: <20160719044820.GA80986@jaegeuk> (raw)
In-Reply-To: <20160719034736.GA4037@infradead.org>
On Mon, Jul 18, 2016 at 08:47:36PM -0700, Christoph Hellwig wrote:
> On Sat, Jul 16, 2016 at 11:24:27PM -0700, Jaegeuk Kim wrote:
> > This patch implements clone_file_range in f2fs.
>
> [...]
>
> > +int f2fs_clone_file_range(struct file *file_in, loff_t pos_in,
> > + struct file *file_out, loff_t pos_out, u64 len)
> > +{
> > + return f2fs_clone_files(file_in, pos_in, file_out, pos_out, len);
> > +}
> > +
>
> Falling back from copy to clone should be done in the VFS. I look into
> implementing the fallback, and the code is trivial, but we don't seem
> to have any useful coverage for copy_file_range yet, so I didn't dare
> to add it yet. How did you test copy and clone in f2fs? And how did
> you handle the difference in corner cases (e.g. the lacking 0 special
> case in copy)?
Frankly speaking, I confused the behaviors without being aware of corner cases.
And thus, I dropped the patches already. Instead, I realized that what I did
was moving a range of blocks from one file to another file. So, I've been
testing a new ioctl, F2FS_IOC_MOVE_RANGE.
In terms of coverage, I just did some unit tests only.
Thanks,
prev parent reply other threads:[~2016-07-19 4:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-17 6:24 [PATCH 1/3] f2fs: avoid memory allocation failure due to a long length Jaegeuk Kim
2016-07-17 6:24 ` [PATCH 2/3] f2fs: support copy_file_range Jaegeuk Kim
2016-07-18 17:19 ` Jaegeuk Kim
2016-07-17 6:24 ` [PATCH 3/3] f2fs: support clone_file_range Jaegeuk Kim
2016-07-19 3:47 ` Christoph Hellwig
2016-07-19 4:48 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719044820.GA80986@jaegeuk \
--to=jaegeuk@kernel.org \
--cc=hch@infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).