From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Brian Norris <briannorris@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Caesar Wang <wxt@rock-chips.com>
Subject: Re: [PATCH] arm64: dts: rockchip: add spiX aliases for rk3399
Date: Tue, 19 Jul 2016 08:39:55 +0200 [thread overview]
Message-ID: <20160719063955.GE5368@pengutronix.de> (raw)
In-Reply-To: <1468545873-134339-1-git-send-email-briannorris@chromium.org>
Hello,
On Thu, Jul 14, 2016 at 06:24:33PM -0700, Brian Norris wrote:
> It's nicer to see this:
>
> # ls -l /sys/bus/spi/devices/
> total 0
> lrwxrwxrwx 1 root root 0 Dec 31 1969 spi0.0 -> ../../../devices/platform/ff1c0000.spi/spi_master/spi0/spi0.0
> lrwxrwxrwx 1 root root 0 Dec 31 1969 spi1.0 -> ../../../devices/platform/ff1d0000.spi/spi_master/spi1/spi1.0
> lrwxrwxrwx 1 root root 0 Dec 31 1969 spi2.0 -> ../../../devices/platform/ff1e0000.spi/spi_master/spi2/spi2.0
> lrwxrwxrwx 1 root root 0 Dec 31 1969 spi5.0 -> ../../../devices/platform/ff200000.spi/spi_master/spi5/spi5.0
>
> than this:
>
> # ls -l /sys/bus/spi/devices/
> total 0
> lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32763.0 -> ../../../devices/platform/ff200000.spi/spi_master/spi32763/spi32763.0
> lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32764.0 -> ../../../devices/platform/ff1e0000.spi/spi_master/spi32764/spi32764.0
> lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32765.0 -> ../../../devices/platform/ff1d0000.spi/spi_master/spi32765/spi32765.0
> lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32766.0 -> ../../../devices/platform/ff1c0000.spi/spi_master/spi32766/spi32766.0
>
> With the latter, it's much clearer which bus devices are on.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 4c84229789ef..b04abbfd4898 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -70,6 +70,12 @@
> serial2 = &uart2;
> serial3 = &uart3;
> serial4 = &uart4;
> + spi0 = &spi0;
> + spi1 = &spi1;
> + spi2 = &spi2;
> + spi3 = &spi3;
> + spi4 = &spi4;
> + spi5 = &spi5;
Note that Rob Herring (with his dt-maintainer hat on) doesn't like these
aliases.
See for example:
http://mid.gmane.org/20160705140546.GA10601@rob-hp-laptop
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2016-07-19 6:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 1:24 [PATCH] arm64: dts: rockchip: add spiX aliases for rk3399 Brian Norris
2016-07-18 20:50 ` Heiko Stübner
2016-07-19 6:39 ` Uwe Kleine-König [this message]
2016-07-19 18:56 ` Heiko Stübner
2016-07-19 19:27 ` Brian Norris
2016-07-19 19:29 ` Brian Norris
2016-07-19 22:18 ` Heiko Stübner
2016-07-20 8:11 ` Heiko Stübner
2016-07-29 23:39 ` Brian Norris
2016-07-30 1:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719063955.GE5368@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=briannorris@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).