From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752736AbcGTAVl (ORCPT ); Tue, 19 Jul 2016 20:21:41 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:34988 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752184AbcGTAVi (ORCPT ); Tue, 19 Jul 2016 20:21:38 -0400 Date: Wed, 20 Jul 2016 01:21:18 +0100 From: Mark Brown To: John Stultz Cc: lkml , Andy Green , Zhangfei Gao , Jingoo Han , Krzysztof Kozlowski , Maxime Ripard , Vinod Koul , Dan Williams , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Wei Xu , Rob Herring , Andy Green , Dave Long , Guodong Xu Message-ID: <20160720002118.GA6509@sirena.org.uk> References: <1468635207-20065-1-git-send-email-john.stultz@linaro.org> <1468635207-20065-7-git-send-email-john.stultz@linaro.org> <20160716114418.GP30372@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s" Content-Disposition: inline In-Reply-To: X-Cookie: It's later than you think. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 19, 2016 at 02:59:31PM -0700, John Stultz wrote: > Then the probe/remove logic to register the codec, and connected it up > with the simple card driver. > Though it seems kind of silly to have a whole driver (and devicetree > entry for the probe hook) just to fill and install the above > structure. Is there a simpler way to specify that via a DT node > instead? Well, if you can use simple-card why not just use simple-card? > >> +static const struct of_device_id hi6210_i2s_dt_ids[] = { > >> + { .compatible = "hisilicon,hi6210-i2s" }, > >> + { /* sentinel */ } > >> +}; > > The code makes this look like it's not just an I2S controller. > I'm not sure I follow this? The dt ids make it seem like this driver > is not an i2s controller? No. The *code* makes this look like it's not an I2S controller. It looks like it's a driver for a DSP/mixing block which may have an integrated I2S controller, I pointed out things like some of the routing control. --SLDf9lqlvOQaIe6s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXjsP6AAoJECTWi3JdVIfQ+iYH/RSiPTfIWk9WT78c8+tkMExC BC1KwtU7OkDAcJ4sqJqRzx0U7vvsOoVWzjfsvGzZBtiprP4Y16YUC2bO6vWo0FHf 20pOZVYgPZcqi+uV1QF24eonIaJNRBEhW15XDLNidCi85UFklswVfjryL3wl7G0U KDUmnkLkiS2fNcIj31SeQPKs8esNKSiwvXikA4efxYVk+7upXsZm7sg+8hP8/Oul 76fv2Edb3P9vXDwHRWZH4sI6NtNZIweEoSc3XPSCqcUxjFuSOy2aUNw/XBmQDjeX mEYiZjW5yq7wNe2MkS3MtCdGJ1cOgrpn9Ao6iOEvAQmZFYHV64C2TGDVIjf+spc= =efLp -----END PGP SIGNATURE----- --SLDf9lqlvOQaIe6s--