From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752019AbcGUHr1 (ORCPT ); Thu, 21 Jul 2016 03:47:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42610 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751791AbcGUHrZ (ORCPT ); Thu, 21 Jul 2016 03:47:25 -0400 Date: Thu, 21 Jul 2016 09:47:22 +0200 From: Jiri Olsa To: Mathieu Poirier Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration Message-ID: <20160721074722.GB7192@krava> References: <1469047100-18131-1-git-send-email-mathieu.poirier@linaro.org> <1469047100-18131-4-git-send-email-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469047100-18131-4-git-send-email-mathieu.poirier@linaro.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 21 Jul 2016 07:47:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 20, 2016 at 02:38:17PM -0600, Mathieu Poirier wrote: SNIP > diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h > index d1edbf8cc66a..8d09a976fca8 100644 > --- a/tools/perf/util/parse-events.h > +++ b/tools/perf/util/parse-events.h > @@ -71,6 +71,7 @@ enum { > PARSE_EVENTS__TERM_TYPE_MAX_STACK, > PARSE_EVENTS__TERM_TYPE_NOOVERWRITE, > PARSE_EVENTS__TERM_TYPE_OVERWRITE, > + PARSE_EVENTS__TERM_TYPE_DRV_CFG, > __PARSE_EVENTS__TERM_TYPE_NR, > }; > > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > index 7a2519435da0..1f7e11a6c5b3 100644 > --- a/tools/perf/util/parse-events.l > +++ b/tools/perf/util/parse-events.l > @@ -53,6 +53,16 @@ static int str(yyscan_t scanner, int token) > return token; > } > > +static int drv_str(yyscan_t scanner, int token) > +{ > + YYSTYPE *yylval = parse_events_get_lval(scanner); > + char *text = parse_events_get_text(scanner); > + > + /* Strip off the '@' */ > + yylval->str = strdup(text + 1); > + return token; > +} why don't let bison parse this with rule like: | '@' PE_DRV_CFG_TERM { ... } you could omit the drv_str function then thanks, jirka