From: Peter Chen <hzpeterchen@gmail.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Peter Chen <peter.chen@nxp.com>,
gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
ulf.hansson@linaro.org, broonie@kernel.org, sre@kernel.org,
robh+dt@kernel.org, shawnguo@kernel.org, dbaryshkov@gmail.com,
dwmw2@infradead.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, k.kozlowski@samsung.com,
stephen.boyd@linaro.org, oscar@naiandei.net, arnd@arndb.de,
pawel.moll@arm.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, s.hauer@pengutronix.de,
linux-usb@vger.kernel.org, mail@maciej.szmigiero.name,
troy.kisky@boundarydevices.com, stillcompiling@gmail.com,
Peter Chen <peter.chen@freescale.com>,
p.zabel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node
Date: Thu, 21 Jul 2016 17:20:12 +0800 [thread overview]
Message-ID: <20160721092012.GA22749@shlinux2> (raw)
In-Reply-To: <20160721091438.GL1041@n2100.armlinux.org.uk>
On Thu, Jul 21, 2016 at 10:14:38AM +0100, Russell King - ARM Linux wrote:
> On Wed, Jul 20, 2016 at 05:40:28PM +0800, Peter Chen wrote:
> > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> > index 69426e6..0d05812 100644
> > --- a/drivers/usb/chipidea/core.c
> > +++ b/drivers/usb/chipidea/core.c
> > @@ -914,6 +914,16 @@ static int ci_hdrc_probe(struct platform_device *pdev)
> > if (!ci)
> > return -ENOMEM;
> >
> > + /*
> > + * At device tree, we have no device node for chipidea core,
> > + * the glue layer's node is the parent node for host and udc
> > + * device. But in related driver, the parent device is chipidea
> > + * core. So, in order to let the common driver get parent's node,
> > + * we let the core's device node equals glue layer's node.
> > + */
> > + if (dev->parent && dev->parent->of_node)
> > + dev->of_node = dev->parent->of_node;
>
> This is a dangerous thing to do. You're changing the dev->of_node of
> _this_ device, which means that _this_ driver will no longer match
> the device if you remove and reinsert the driver module, or unbind
> and try to re-bind the device to this driver.
>
Thanks for commenting it.
I have tested load/unload, it does not show any problems.
The chipidea core device is created by code at runtime, not by device node.
And we have NO device node for this chipidea core device at dts.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-07-21 9:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 9:40 [PATCH v3 0/6] power: add power sequence library Peter Chen
2016-07-20 9:40 ` [PATCH v3 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic " Peter Chen
2016-07-29 2:09 ` Peter Chen
2016-07-29 21:09 ` Rob Herring
2016-07-20 9:40 ` [PATCH v3 2/6] power: add " Peter Chen
2016-07-29 20:06 ` [v3,2/6] " Matthias Kaehlcke
2016-08-01 1:58 ` Peter Chen
2016-08-02 3:32 ` Peter Chen
2016-07-20 9:40 ` [PATCH v3 3/6] binding-doc: usb: usb-device: add optional properties for power sequence Peter Chen
2016-07-29 21:11 ` Rob Herring
2016-07-20 9:40 ` [PATCH v3 4/6] usb: core: add power sequence handling for USB devices Peter Chen
2016-07-27 16:25 ` Joshua Clayton
2016-07-28 1:45 ` Peter Chen
2016-07-28 16:18 ` Joshua Clayton
2016-07-20 9:40 ` [PATCH v3 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node Peter Chen
2016-07-21 9:14 ` Russell King - ARM Linux
2016-07-21 9:20 ` Peter Chen [this message]
2016-07-21 9:41 ` Russell King - ARM Linux
2016-07-21 10:12 ` Peter Chen
2016-07-20 9:40 ` [PATCH v3 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Peter Chen
2016-07-28 15:56 ` [PATCH v3 0/6] power: add power sequence library Joshua Clayton
2016-07-28 16:41 ` Fabio Estevam
2016-08-01 14:55 ` Joshua Clayton
2016-08-01 16:29 ` Fabio Estevam
2016-08-02 1:08 ` Peter Chen
2016-07-29 1:46 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721092012.GA22749@shlinux2 \
--to=hzpeterchen@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mail@maciej.szmigiero.name \
--cc=mark.rutland@arm.com \
--cc=oscar@naiandei.net \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=peter.chen@freescale.com \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sre@kernel.org \
--cc=stephen.boyd@linaro.org \
--cc=stern@rowland.harvard.edu \
--cc=stillcompiling@gmail.com \
--cc=troy.kisky@boundarydevices.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).