From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754203AbcGUVAq (ORCPT ); Thu, 21 Jul 2016 17:00:46 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:52414 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754031AbcGUVAo (ORCPT ); Thu, 21 Jul 2016 17:00:44 -0400 Date: Thu, 21 Jul 2016 15:00:24 -0600 From: Jason Gunthorpe To: Andrey Pronin Cc: Jarkko Sakkinen , Peter Huewe , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, groeck@chromium.org, smbarber@chromium.org, dianders@chromium.org, Christophe Ricard Subject: Re: [PATCH 2/2] tpm: add driver for cr50 on SPI Message-ID: <20160721210024.GA10039@obsidianresearch.com> References: <1468549218-19215-1-git-send-email-apronin@chromium.org> <1468549218-19215-3-git-send-email-apronin@chromium.org> <20160715033236.GH9347@obsidianresearch.com> <20160715034444.GA28128@apronin> <20160719125527.GB5047@intel.com> <20160720002411.GA147098@apronin> <20160720170336.GC21460@obsidianresearch.com> <20160721181047.GA115653@apronin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160721181047.GA115653@apronin> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2016 at 11:10:47AM -0700, Andrey Pronin wrote: > On Wed, Jul 20, 2016 at 11:03:36AM -0600, Jason Gunthorpe wrote: > > On Tue, Jul 19, 2016 at 05:24:11PM -0700, Andrey Pronin wrote: > > > > > The only two things that bother me with such approach are > > > (1) whatever names I pick for the new set of functions, they > > > will be similar to and thus might be confused with the > > > original tpm_tis_read/writeXX; > > > > tpm_tis_helper_read16 ? > > > > > (2) these functions are phy-specific, so possibly it's better > > > to create tpm_tis_spi.h and put them there with proper > > > name prefixes. And then use in tpm_tis_spi and cr50_spi. > > > > No, they are generic to any tis phy that implements read only through > > read_bytes. > > > > (Honestly, I'm not sure we made the best choice here having phy > > functions for all the versions, we are not that performance > > sensitive, just getting rid of everything but read_bytes from the > > phy_ops would probably also be a reasonable thing to do.) > > > > One thing we can do is re-implement functions tpm_tis_read/writeXX > to use phy-specific implementations of read16, read32, write32 if they > are provided. But if those function pointers are left NULL in phy_ops, > fallback to using read/write_bytes and byte-swapping. I was thinking of just getting rid of phy_ops->read16 entirely and only use read_bytes at the ops layer. Jason