From: Guenter Roeck <linux@roeck-us.net>
To: Hoan Tran <hotran@apm.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Rob Herring <robh+dt@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
Duc Dang <dhdang@apm.com>,
lho@apm.com, linux-hwmon@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver
Date: Thu, 21 Jul 2016 15:09:35 -0700 [thread overview]
Message-ID: <20160721220935.GB19236@roeck-us.net> (raw)
In-Reply-To: <1469134557-26869-3-git-send-email-hotran@apm.com>
On Thu, Jul 21, 2016 at 01:55:56PM -0700, Hoan Tran wrote:
> This patch adds hardware temperature and power reading support for
> APM X-Gene SoC using the mailbox communication interface.
>
> Signed-off-by: Hoan Tran <hotran@apm.com>
> ---
[ ... ]
> +
> + dev_info(&pdev->dev, "APM X-Gene SoC HW monitor driver registered\n");
> +
> + return rc;
> +
Nitpick: rc == 0 here, so return 0; is a better choice.
Otherwise looks good.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Note that I can not apply the patch at this time due to its dependency.
Guenter
next prev parent reply other threads:[~2016-07-21 22:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 20:55 [PATCH v3 0/3] hwmon: xgene: Add support for X-Gene hwmon driver Hoan Tran
2016-07-21 20:55 ` [PATCH v3 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation Hoan Tran
2016-07-21 22:02 ` Guenter Roeck
2016-07-21 20:55 ` [PATCH v3 2/3] hwmon: xgene: Add hwmon driver Hoan Tran
2016-07-21 22:09 ` Guenter Roeck [this message]
2016-07-21 22:21 ` Hoan Tran
2016-08-01 13:21 ` kbuild test robot
2016-08-01 16:39 ` Hoan Tran
2016-09-07 21:41 ` Arnd Bergmann
2016-09-07 22:27 ` Guenter Roeck
2016-09-08 8:15 ` Arnd Bergmann
2016-09-08 14:55 ` Guenter Roeck
2016-09-08 14:59 ` Arnd Bergmann
2016-09-07 22:37 ` Guenter Roeck
2016-09-08 8:14 ` Arnd Bergmann
2016-09-08 10:47 ` James Morse
2016-09-09 3:18 ` AKASHI Takahiro
2016-09-09 9:31 ` James Morse
2016-09-09 15:38 ` Arnd Bergmann
2016-09-09 15:38 ` [PATCH] hwmon: xgene: access mailbox as RAM Arnd Bergmann
2016-09-09 16:58 ` Guenter Roeck
2016-09-09 17:05 ` Hoan Tran
2016-09-09 19:24 ` Hoan Tran
2016-09-09 19:58 ` Arnd Bergmann
2016-09-09 20:10 ` [PATCH v2] " Arnd Bergmann
2016-09-09 20:47 ` Hoan Tran
2016-09-09 21:56 ` Guenter Roeck
2016-09-09 20:43 ` [PATCH] " Hoan Tran
2016-09-09 20:50 ` Arnd Bergmann
2016-09-09 20:51 ` Hoan Tran
2016-07-21 20:55 ` [PATCH v3 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree Hoan Tran
2016-07-21 22:09 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721220935.GB19236@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ashwin.chaugule@linaro.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dhdang@apm.com \
--cc=hotran@apm.com \
--cc=jassisinghbrar@gmail.com \
--cc=jdelvare@suse.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).