From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753309AbcGYRq7 (ORCPT ); Mon, 25 Jul 2016 13:46:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41575 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753229AbcGYRq5 (ORCPT ); Mon, 25 Jul 2016 13:46:57 -0400 Date: Mon, 25 Jul 2016 10:47:12 -0700 From: Greg KH To: Max Staudt Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] 8250: option 'force_polling' for buggy IRQs Message-ID: <20160725174712.GA5752@kroah.com> References: <1469468175-15704-1-git-send-email-mstaudt@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469468175-15704-1-git-send-email-mstaudt@suse.de> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 25, 2016 at 07:36:15PM +0200, Max Staudt wrote: > Some serial ports may not emit IRQs properly, or there may be a defect > in their routing on the motherboard. > > This patch allows these ports to be used anyway (or until a better > workaround is known for a specific platform), though with no guarantees. > > If you have such a buggy UART, boot Linux with 8250.force_polling=1 . Ick, don't add new module parameters if at all possible. > It is essentially the kernel level version of: > > setserial /dev/ttySn irq 0 Why can't you just do this instead? thanks, greg k-h