From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757414AbcGZWT2 (ORCPT ); Tue, 26 Jul 2016 18:19:28 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:41898 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756073AbcGZWTX (ORCPT ); Tue, 26 Jul 2016 18:19:23 -0400 Date: Tue, 26 Jul 2016 15:19:21 -0700 (PDT) Message-Id: <20160726.151921.304567441512097113.davem@davemloft.net> To: bhaktipriya96@gmail.com Cc: matanb@mellanox.com, leonro@mellanox.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, tj@kernel.org Subject: Re: [PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue From: David Miller In-Reply-To: <20160726170824.GA10721@Karyakshetra> References: <20160717051327.GA20674@leon.nu> <20160726170824.GA10721@Karyakshetra> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 Jul 2016 15:19:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bhaktipriya Shridhar Date: Tue, 26 Jul 2016 22:38:24 +0530 > The workqueue health->wq was used as per device private health thread. > This was done to perform delayed work. > > The workqueue has a single workitem(&health->work) and > hence doesn't require ordering. It is involved in handling the health of > the device and is not being used on a memory reclaim path. > Hence, the singlethreaded workqueue has been replaced with the use of > system_wq. > > Work item has been flushed in mlx5_health_cleanup() to ensure that > there are no pending tasks while disconnecting the driver. > > Signed-off-by: Bhaktipriya Shridhar Applied.