From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758657AbcGZW0M (ORCPT ); Tue, 26 Jul 2016 18:26:12 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42042 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758634AbcGZW0J (ORCPT ); Tue, 26 Jul 2016 18:26:09 -0400 Date: Tue, 26 Jul 2016 15:26:07 -0700 (PDT) Message-Id: <20160726.152607.1736959777881968300.davem@davemloft.net> To: Julia.Lawall@lip6.fr Cc: kernel-janitors@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org, josh@joshtriplett.org Subject: Re: [PATCH 5/5] cmd640: add __init attribute From: David Miller In-Reply-To: <1460991338-9845-6-git-send-email-Julia.Lawall@lip6.fr> References: <1460991338-9845-1-git-send-email-Julia.Lawall@lip6.fr> <1460991338-9845-6-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 Jul 2016 15:26:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall Date: Mon, 18 Apr 2016 16:55:38 +0200 > Add __init attribute on a function that is only called from other __init > functions and that is not inlined, at least with gcc version 4.8.4 on an > x86 machine with allyesconfig. Currently, the function is put in the > .text.unlikely segment. Declaring it as __init will cause it to be put in > the .init.text and to disappear after initialization. > > The result of objdump -x on the function before the change is as follows: > > 0000000000000000 l F .text.unlikely 00000000000000e4 cmd640x_init_one > > And after the change it is as follows: > > 00000000000000d2 l F .init.text 00000000000000df cmd640x_init_one > > Done with the help of Coccinelle. The semantic patch checks for local > static non-init functions that are called from an __init function and are > not called from any other function. > > Signed-off-by: Julia Lawall Applied.