On Tue, Jul 26, 2016 at 10:38:24PM +0530, Bhaktipriya Shridhar wrote: > The workqueue health->wq was used as per device private health thread. > This was done to perform delayed work. > > The workqueue has a single workitem(&health->work) and > hence doesn't require ordering. It is involved in handling the health of > the device and is not being used on a memory reclaim path. > Hence, the singlethreaded workqueue has been replaced with the use of > system_wq. > > Work item has been flushed in mlx5_health_cleanup() to ensure that > there are no pending tasks while disconnecting the driver. > > Signed-off-by: Bhaktipriya Shridhar > --- > Changes in v2: > -Updated commit description as per the feedback received. > > drivers/net/ethernet/mellanox/mlx5/core/health.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Thanks, Acked-by: Leon Romanovsky