From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756924AbcG0PYR (ORCPT ); Wed, 27 Jul 2016 11:24:17 -0400 Received: from smtprelay0114.hostedemail.com ([216.40.44.114]:34646 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755485AbcG0PYP (ORCPT ); Wed, 27 Jul 2016 11:24:15 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2892:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3870:3874:4321:5007:6261:6742:7514:7875:10004:10400:10848:10967:11026:11232:11658:11914:12043:12438:12517:12519:12663:12740:13069:13161:13229:13311:13357:13439:14181:14659:14721:21080:30012:30054:30070:30075:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: nose02_7beb1a83e60e X-Filterd-Recvd-Size: 1799 Date: Wed, 27 Jul 2016 11:24:11 -0400 From: Steven Rostedt To: Janani Ravichandran Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, riel@surriel.com, akpm@linux-foundation.org, hannes@compxchg.org, vdavydov@virtuozzo.com, mhocko@suse.com, vbabka@suse.cz, mgorman@techsingularity.net, kirill.shutemov@linux.intel.com, bywxiaobai@163.com Subject: Re: [PATCH 2/2] mm: compaction.c: Add/Modify direct compaction tracepoints Message-ID: <20160727112411.6e60c186@gandalf.local.home> In-Reply-To: <7d2c2beef96e76cb01a21eee85ba5611bceb4307.1469629027.git.janani.rvchndrn@gmail.com> References: <7d2c2beef96e76cb01a21eee85ba5611bceb4307.1469629027.git.janani.rvchndrn@gmail.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Jul 2016 10:51:03 -0400 Janani Ravichandran wrote: > Add zone information to an existing tracepoint in compact_zone(). Also, > add a new tracepoint at the end of the compaction code so that latency > information can be derived. > > Signed-off-by: Janani Ravichandran > --- > > + trace_mm_compaction_try_to_compact_pages_end(rc, *contended); > + Again, I'm not to thrilled about tracepoints just being added to track the length of function calls. We have function graph tracer for that. -- Steve > return rc; > } >