From: "Theodore Ts'o" <tytso@mit.edu>
To: Max Staudt <mstaudt@suse.de>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Greg KH <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 8250: option 'force_polling' for buggy IRQs
Date: Wed, 27 Jul 2016 09:33:48 -0400 [thread overview]
Message-ID: <20160727133348.GB20032@thunk.org> (raw)
In-Reply-To: <2b140616-c210-e754-a854-cd6a5675277d@suse.de>
On Wed, Jul 27, 2016 at 02:14:24PM +0200, Max Staudt wrote:
> > If you set the IRQ to 0 it should poll anyway (0 means 'no IRQ') so I
> > don't think the option is needed. At least it seems sufficient to get me
> > by when I meet buggy PC BIOSes and the like
>
> That's exactly what the patch does - but if there is already a way to set the
> IRQ to 0, I would of course prefer to use that.
>
> It seems I haven't found the trick you're using - could you please tell me how
> you set the IRQ to 0? I can't change it in the BIOS, so I have to do it at
> the kernel level at the latest.
So the problem is that you can't use setserial because you want to use
this port for your console? And so you don't want to set it in an initscript?
The one thing which is really unfortunate with this patch is that it's
a global, so it forces polling for *all* serial ports. And it may be
that it's only base ports on the motherboard which needs this hack.
I wonder if it would just be simpler to make it be a CONFIG option
which causes the irq value to zero in arch/x86/include/asm/serial.h?
- Ted
next prev parent reply other threads:[~2016-07-27 13:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 17:36 [PATCH] 8250: option 'force_polling' for buggy IRQs Max Staudt
2016-07-25 17:47 ` Greg KH
2016-07-26 11:42 ` Max Staudt
2016-07-26 15:08 ` Greg KH
2016-07-26 16:18 ` Max Staudt
2016-07-27 12:09 ` One Thousand Gnomes
2016-07-27 12:14 ` Max Staudt
2016-07-27 13:33 ` Theodore Ts'o [this message]
2016-07-27 20:01 ` One Thousand Gnomes
2016-07-28 9:59 ` Max Staudt
2016-07-28 14:47 ` Greg KH
2016-07-28 16:01 ` Theodore Ts'o
2016-07-28 18:40 ` Eric W. Biederman
2016-07-29 9:23 ` One Thousand Gnomes
2016-07-29 9:58 ` Max Staudt
2016-07-29 17:38 ` Eric W. Biederman
2016-08-01 15:27 ` One Thousand Gnomes
2016-07-25 18:19 ` kbuild test robot
2016-07-26 11:47 ` [PATCHv2] " Max Staudt
2016-07-26 11:54 ` [PATCHv3] " Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160727133348.GB20032@thunk.org \
--to=tytso@mit.edu \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mstaudt@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).