From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932103AbcG0QjC (ORCPT ); Wed, 27 Jul 2016 12:39:02 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:56568 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756828AbcG0QjA (ORCPT ); Wed, 27 Jul 2016 12:39:00 -0400 Date: Wed, 27 Jul 2016 09:38:57 -0700 From: Darren Hart To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Mario_Limonciello@dell.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Message-ID: <20160727163857.GA2565@f23x64.localdomain> References: <1469217684-6643-1-git-send-email-mario_limonciello@dell.com> <20160727072350.GF29844@pali> <1469634909478.10239@Dell.com> <201607271805.57123@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201607271805.57123@pali> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 27, 2016 at 06:05:57PM +0200, Pali Rohár wrote: > On Wednesday 27 July 2016 17:55:09 Mario_Limonciello@dell.com wrote: > > > Hi! I'm not sure if KEY_PROG1/2/3 are good names here as we already > > > use > > > > > >those for other actions (see bios_to_linux_keycode). Also there is: > > I had missed this, do you have some recommendations on what would be > > better codes to map this to? > > Problem is that I do not know when those KEY_PROG keys from > bios_to_linux_keycode table are emitted. There are missing comments or > description. > > Are you able to find out description for all those keys in that table? > Maybe now (when linux key constants are extended), there could be better > candidates... > > > I'll double check what the things that "were" mapping to KEY_PROG1 > > etc actually were. This might be a case of an expected clash if the > > functions aren't in current generations. > > > > >/* Wifi Catcher */ > > > > > > { KE_KEY, 0xe011, { KEY_PROG2 } }, > > > > It's worth mentioning that Wifi Catcher hasn't been used for any Dell > > laptops for a handful generations. The rugged 2in1's are current > > generation that have these programmable buttons and don't have wifi > > catcher. > > Anyway, what is "Wifi Catcher"? HW switch buttton which enable/disable > wifi? Or something else? > > > So there should be no "real" clash here. > > Problem can be in future. This driver is unified for all Dell products > with wmi interface and so future product could do some nasty things... I suggest not worrying too much about unknown future platforms when it comes to things like key names, we cannot predict this, and can address it when/if it becomes a problem. -- Darren Hart Intel Open Source Technology Center