From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757919AbcG1NWD (ORCPT ); Thu, 28 Jul 2016 09:22:03 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33833 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758074AbcG1NVz (ORCPT ); Thu, 28 Jul 2016 09:21:55 -0400 Date: Thu, 28 Jul 2016 15:21:51 +0200 From: LABBE Corentin To: Rob Herring Cc: mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, davem@davemloft.net, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac Message-ID: <20160728132151.GB7582@Red> References: <1469001800-11615-1-git-send-email-clabbe.montjoie@gmail.com> <1469001800-11615-4-git-send-email-clabbe.montjoie@gmail.com> <20160720191533.GA12875@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160720191533.GA12875@rob-hp-laptop> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 20, 2016 at 02:15:33PM -0500, Rob Herring wrote: > On Wed, Jul 20, 2016 at 10:03:18AM +0200, LABBE Corentin wrote: > > This patch adds documentation for Device-Tree bindings for the > > Allwinner sun8i-emac driver. > > > > Signed-off-by: LABBE Corentin > > --- > > .../bindings/net/allwinner,sun8i-emac.txt | 65 ++++++++++++++++++++++ > > 1 file changed, 65 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt > > > > diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt > > new file mode 100644 > > index 0000000..4bf4e53 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt > > @@ -0,0 +1,65 @@ > > +* Allwinner sun8i EMAC ethernet controller > > + > > +Required properties: > > +- compatible: "allwinner,sun8i-a83t-emac", "allwinner,sun8i-h3-emac", > > + or "allwinner,sun50i-a64-emac" > > List one per line. > ok > > +- reg: address and length of the register sets for the device. > > +- reg-names: should be "emac" and "syscon", matching the register sets > > +- interrupts: interrupt for the device > > +- clocks: A phandle to the reference clock for this device > > +- clock-names: should be "ahb" > > +- resets: A phandle to the reset control for this device > > +- reset-names: should be "ahb" > > +- phy-mode: See ethernet.txt > > +- phy or phy-handle: See ethernet.txt > > +- #address-cells: shall be 1 > > +- #size-cells: shall be 0 > > + > > +"allwinner,sun8i-h3-emac" also requires: > > +- clocks: an extra phandle to the reference clock for the EPHY > > +- clock-names: an extra "ephy" entry matching the clocks property > > +- resets: an extra phandle to the reset control for the EPHY > > +- resets-names: an extra "ephy" entry matching the resets property > > + > > +See ethernet.txt in the same directory for generic bindings for ethernet > > +controllers. > > + > > +The device node referenced by "phy" or "phy-handle" should be a child node > > +of this node. See phy.txt for the generic PHY bindings. > > + > > +Optional properties: > > +- phy-supply: phandle to a regulator if the PHY needs one > > +- phy-io-supply: phandle to a regulator if the PHY needs a another one for I/O. > > + This is sometimes found with RGMII PHYs, which use a second > > + regulator for the lower I/O voltage. > > I previously said these should go in the phy node, and you said you > would remove them. > > Rob Sorry, I forgot to remove them. I have removed them now. Regards Thanks LABBE Corentin