From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756713AbcG1SmW (ORCPT ); Thu, 28 Jul 2016 14:42:22 -0400 Received: from smtprelay0014.hostedemail.com ([216.40.44.14]:55418 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753876AbcG1SmT (ORCPT ); Thu, 28 Jul 2016 14:42:19 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:967:973:982:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2859:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6261:7514:7576:7875:7901:7903:8957:9025:9391:10004:10400:10848:10913:10967:11026:11232:11657:11658:11914:12043:12517:12519:12555:12740:12783:13069:13138:13231:13311:13357:13439:13846:14181:14659:14721:14777:21080:21433:21451:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: copy52_30fe7e337c512 X-Filterd-Recvd-Size: 2938 Date: Thu, 28 Jul 2016 14:42:15 -0400 From: Steven Rostedt To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Jiri Olsa , David Ahern , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: Re: [PATCH 13/15] perf script python: Fix string vs byte array resolving Message-ID: <20160728144215.3c62b0a0@gandalf.local.home> In-Reply-To: <1468884798-14932-14-git-send-email-acme@kernel.org> References: <1468884798-14932-1-git-send-email-acme@kernel.org> <1468884798-14932-14-git-send-email-acme@kernel.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Jul 2016 20:33:16 -0300 Arnaldo Carvalho de Melo wrote: > From: Jiri Olsa > > Jirka reported that python code returns all arrays as strings. This > makes impossible to get all items for byte array tracepoint field > containing 0x00 value item. > > Fixing this by scanning full length of the array and returning it as > PyByteArray object in case non printable byte is found. > > Signed-off-by: Jiri Olsa > Reported-and-Tested-by: Jiri Pirko > Cc: David Ahern > Cc: Namhyung Kim > Cc: Peter Zijlstra > Cc: Steven Rostedt > Link: http://lkml.kernel.org/r/1468685480-18951-2-git-send-email-jolsa@kernel.org > Signed-off-by: Arnaldo Carvalho de Melo > --- > .../util/scripting-engines/trace-event-python.c | 39 ++++++++++++++++++---- > 1 file changed, 33 insertions(+), 6 deletions(-) > > diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c > index 6ac6b7a33f42..7bd6da80533e 100644 > --- a/tools/perf/util/scripting-engines/trace-event-python.c > +++ b/tools/perf/util/scripting-engines/trace-event-python.c > @@ -386,6 +386,21 @@ exit: > return pylist; > } > > +static int is_printable_array(char *p, unsigned int len) > +{ > + unsigned int i; > + > + if (!p || !len || p[len - 1] != 0) > + return 0; > + > + len--; > + > + for (i = 0; i < len; i++) { > + if (!isprint(p[i]) && !isspace(p[i])) > + return 0; > + } > + return 1; > +} > Darn, I never got to add my Reviewed-by tag, as I had lots of comments on this function. Oh well, that's what happens when you go off to volcanoes. -- Steve