From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161039AbcG1P5v (ORCPT ); Thu, 28 Jul 2016 11:57:51 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:44790 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161006AbcG1P5u (ORCPT ); Thu, 28 Jul 2016 11:57:50 -0400 Date: Thu, 28 Jul 2016 16:57:32 +0100 From: Mark Brown To: Nicolin Chen Cc: lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, bardliao@realtek.com, oder_chiou@realtek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, vinod.koul@intel.com Message-ID: <20160728155732.GG11806@sirena.org.uk> References: <1469660568-3511-1-git-send-email-nicoleotsuka@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hX3v94LCWtOgt2h1" Content-Disposition: inline In-Reply-To: <1469660568-3511-1-git-send-email-nicoleotsuka@gmail.com> X-Cookie: Are you still an ALCOHOLIC? User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: rt5659: Add mclk controls X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hX3v94LCWtOgt2h1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 27, 2016 at 04:02:48PM -0700, Nicolin Chen wrote: > The codec driver should control the mclk. So this patch adds this support. > + /* Check if MCLK provided */ > + rt5659->mclk = devm_clk_get(&i2c->dev, "mclk"); > + if (IS_ERR(rt5659->mclk)) { > + if (PTR_ERR(rt5659->mclk) == -EPROBE_DEFER) > + return -EPROBE_DEFER; > + /* Otherwise mark the mclk pointer to NULL */ > + rt5659->mclk = NULL; > + } This device seems to be used on x86 systems so we'll need to ensure that they register clocks for this. They really should set this up using quirks keyed off DMI information or similar so it's hidden from other systems. --hX3v94LCWtOgt2h1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXmitqAAoJECTWi3JdVIfQpp4H/19ATmfl1VRcjaF7lc14wijU bFCBPOLgOTZLlYWp5hY6Q+5ppTZxbheQ0X7uVzXMGt2Sh9OarDa+/J2wZ3XSDfFf ENQ3FdNab2llVZns0qw/nuEhQyVQnJnJndD6KGlY5l5ESXUUr4Emy7Pi8Z95rTXG TBc1vpgNFN6PA4UsugDdGO8Zwn10y9cAVYZnQ+6R4cb4Otic+emugOlgN1K5WxXd yN9LqJoRynOj+b/a3AuSe2Y++4pHD7jmGD+gf0MeLz5nz6QhPYyuvx2lSSXhhcC7 /kIZ1WcusOs1WzyI2PAt6Dwx6NzFoKpe6m0/LrR0ORB58pL2u6y94SFh/HIa0Aw= =t2qj -----END PGP SIGNATURE----- --hX3v94LCWtOgt2h1--