From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756985AbcG1StW (ORCPT ); Thu, 28 Jul 2016 14:49:22 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59412 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755469AbcG1StT (ORCPT ); Thu, 28 Jul 2016 14:49:19 -0400 Date: Thu, 28 Jul 2016 20:49:16 +0200 From: Maxime Ripard To: LABBE Corentin Cc: robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, davem@davemloft.net, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac Message-ID: <20160728184916.GF6682@lukather> References: <1469001800-11615-1-git-send-email-clabbe.montjoie@gmail.com> <1469001800-11615-4-git-send-email-clabbe.montjoie@gmail.com> <20160721075519.GC5993@lukather> <20160728134031.GC7582@Red> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vKFfOv5t3oGVpiF+" Content-Disposition: inline In-Reply-To: <20160728134031.GC7582@Red> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vKFfOv5t3oGVpiF+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 28, 2016 at 03:40:31PM +0200, LABBE Corentin wrote: > On Thu, Jul 21, 2016 at 09:55:19AM +0200, Maxime Ripard wrote: > > Hi, > >=20 > > On Wed, Jul 20, 2016 at 10:03:18AM +0200, LABBE Corentin wrote: > > > This patch adds documentation for Device-Tree bindings for the > > > Allwinner sun8i-emac driver. > > >=20 > > > Signed-off-by: LABBE Corentin > > > --- > > > .../bindings/net/allwinner,sun8i-emac.txt | 65 ++++++++++++= ++++++++++ > > > 1 file changed, 65 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/net/allwinner,s= un8i-emac.txt > > >=20 > > > diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-em= ac.txt b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt > > > new file mode 100644 > > > index 0000000..4bf4e53 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt > > > @@ -0,0 +1,65 @@ > > > +* Allwinner sun8i EMAC ethernet controller > > > + > > > +Required properties: > > > +- compatible: "allwinner,sun8i-a83t-emac", "allwinner,sun8i-h3-emac", > > > + or "allwinner,sun50i-a64-emac" > > > +- reg: address and length of the register sets for the device. > > > +- reg-names: should be "emac" and "syscon", matching the register se= ts > >=20 > > Blindly mapping a register of some other device on the SoC doesn't > > look very reasonable. >=20 > As we discuss after this mail on IRC, this register is dedicated to EMAC. I don't think we did. It's still right in the middle of some other hardware block register space. You actually have a syscon driver to do just that, why not use it? > > > +See ethernet.txt in the same directory for generic bindings for ethe= rnet > > > +controllers. > > > + > > > +The device node referenced by "phy" or "phy-handle" should be a chil= d node > > > +of this node. See phy.txt for the generic PHY bindings. > > > + > > > +Optional properties: > > > +- phy-supply: phandle to a regulator if the PHY needs one > > > +- phy-io-supply: phandle to a regulator if the PHY needs a another o= ne for I/O. > > > + This is sometimes found with RGMII PHYs, which use a second > > > + regulator for the lower I/O voltage. > > > +- allwinner,tx-delay: The setting of the TX clock delay chain > > > +- allwinner,rx-delay: The setting of the RX clock delay chain > >=20 > > In which unit? What is the default value? >=20 > The unit is unknown to me, but I have added a comment for the > default and acceptable range value. That's unfortunate. We'll see how the DT maintainers feel about that. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --vKFfOv5t3oGVpiF+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXmlOsAAoJEBx+YmzsjxAg8I4P/iyUzIWUyb0HkOrX5MlUIivR Zy7ufUVkHP1jc2UpeSZjr9fTb+fn6OrzpKuiJ7NXH8MudbO9815TqpdSOy033aDK D5fvRYUlvMdK7EC5DBK6BIOhMvjt5MNGOvLRKi4Oxr+kR09yS9xfPy2Mh+2+dnOm LuhP1JdiTVf2tEpnutp6DLTRP5QRSmqLOVhJRJfLOHfeX/zwdfL1zY8zXBmyhpbE Qp7HSVvQXTGMqrTW3Fi51pWu67cDx8/MeL9EwbCap/bFDhbrmHkJGwQGAu7cUqTM ukMhgtsorvqXTWodX86nMNc/hdKQ6QK+jEJ6qXVAZFbwW/NBbKUvEB0UC00V6pVt DPZwhhbl5sxuahStRCn48FxF0iVPMq64VQw8UMeklr+zEAR4o4AUNw4QjU95ZoNm 0+sOOR5ZaOx2tn/LYYJyfglDr9bG9IDehr2ddchQqDCkMY8A/XOjlm/0EXq3wdD6 lSjj5wD89yrgt3KtZLzVT3jQVu5ItDiZgbYPzh8i7PvtJ+NLEv+rNjRvdoyHTVDZ x0RgG5C4yj5Jktpq4+GUGHrNWuKYRbhmDg2qGv8qRuQ0KpLm+nrznWvtHAjUK8oV qjVyjkyVXzA06KIXtUx4okAWCY8zYF3E5MC3t2kRKnpZvihtwgV594D6bmGaFu8A AlPQDuFAOIuTSkBQvlJg =LRN6 -----END PGP SIGNATURE----- --vKFfOv5t3oGVpiF+--