From: Mark Brown <broonie@kernel.org>
To: Rich Felker <dalias@libc.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, linux-sh@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v4 2/2] spi: add driver for J-Core SPI controller
Date: Thu, 28 Jul 2016 20:51:25 +0100 [thread overview]
Message-ID: <20160728195125.GN11806@sirena.org.uk> (raw)
In-Reply-To: <20160728194045.GK15995@brightrain.aerifal.cx>
[-- Attachment #1: Type: text/plain, Size: 1550 bytes --]
On Thu, Jul 28, 2016 at 03:40:45PM -0400, Rich Felker wrote:
> On Thu, Jul 28, 2016 at 08:11:53PM +0100, Mark Brown wrote:
> > An architecture or SoC dependency with || COMPILE_TEST would be useful
> > for avoiding cluttering Kconfig for other users. Though as this is in a
> > FPGA it's perhaps likely people will pick this up for other FPGAs so
> > perhaps a comment to that effect if it seems likely.
> Unlike some of the other SoC hardware (interrupt controller) that's
> more closely tied to the SH cpu trap behavior, the SPI master seems
> like something that would be nice and easy to reuse elsewhere. I don't
> feel strongly about it either way though; I can add the arch dep if
> you want.
I guess it depends if anyone is actually doing that or not, if nobody is
the dependency would be better.
> > Why are you not using the clock API for this? Just require a clock and
> > use clk_get_rate() to find out what rate it is.
> I thought about that but I'm not familiar with it. I can try to figure
> it out quickly and test that approach; don't see any reason it
> shouldn't work. Would you insist on having full support for
> enabling/disabling the clk when it's in use, or would you be happy
> with treating it as a fixed clock that's always-on for now and
> possibly extending it with more functionality later if there's ever
> hardware where that's relevant/helpful?
It's fine to just enable it at startup and leave it on, though the
runtime PM ops are trivial and you can set auto_runtime_pm to have the
core do the gets and puts.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-07-28 19:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 6:11 [PATCH v4 0/2] J-Core SPI controller support Rich Felker
2016-04-03 5:12 ` [PATCH v4 2/2] spi: add driver for J-Core SPI controller Rich Felker
2016-07-28 19:11 ` Mark Brown
2016-07-28 19:40 ` Rich Felker
2016-07-28 19:51 ` Mark Brown [this message]
2016-07-30 3:34 ` Rich Felker
2016-08-01 18:12 ` Mark Brown
2016-08-02 1:45 ` Rich Felker
2016-08-02 18:11 ` Rob Landley
2016-08-04 13:05 ` Geert Uytterhoeven
2016-08-04 17:03 ` Rich Felker
2016-05-17 23:19 ` [PATCH v4 1/2] of: add J-Core SPI master bindings Rich Felker
2016-07-29 20:58 ` Rob Herring
2016-08-02 22:00 ` Rich Felker
2016-08-02 22:41 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728195125.GN11806@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dalias@libc.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).