From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758005AbcG1USx (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Jul 2016 16:18:53 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:32830 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757542AbcG1USt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Jul 2016 16:18:49 -0400
Date: Thu, 28 Jul 2016 21:18:46 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] configfs updates for 4.8
Message-ID: <20160728201846.GW2356@ZenIV.linux.org.uk>
References: <20160728133032.GA11941@infradead.org>
 <CA+55aFwgJWLRPJvDaW+gFk9OgDDYDWGR5QrXWpMAphPF4a13wA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFwgJWLRPJvDaW+gFk9OgDDYDWGR5QrXWpMAphPF4a13wA@mail.gmail.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 28, 2016 at 01:05:13PM -0700, Linus Torvalds wrote:
> On Thu, Jul 28, 2016 at 6:30 AM, Christoph Hellwig <hch@infradead.org> wrote:
> >
> >   git://git.infradead.org/users/hch/configfs.git tags/configfs-for-4.8
> >
> > for you to fetch changes up to 3dc3afadeb0403fd967b97ee282ab9053d36da2b:
> 
> Same lack of diffstat..
> 
> There's a reason we have a "git request-pull" helper. You don't have
> to use it (lots of people end up using other things that match their
> workflow better), but you do have to generate something at least as
> good at that.

FWIW, git request-pull is very likely to make complete mess of
diffstat - all it takes is branch started at -rc1, then a merge from
anything started at later point (e.g. Miklos asking to pull ->d_real()
work from his tree into vfs.git, with his branch starting at -rc5).

I've ended up doing git fetch origin; git checkout -b XXX origin; git
merge work.misc; git diff XXX --stat and replacing the mess produced by
git-request-pull with that.  It works, of course, but what worries me
is that less obvious mess could've slipped unnoticed.  Might make sense
to teach git request-pull to warn about likely bogus diffstat...