linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Sheng-Hui J. Chu" <s.jeffrey.chu@gmail.com>
Cc: linux-usb@vger.kernel.org, johan@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board
Date: Thu, 28 Jul 2016 13:30:24 -0700	[thread overview]
Message-ID: <20160728203024.GA1382@kroah.com> (raw)
In-Reply-To: <032101d1e90b$6d353290$479f97b0$@gmail.com>

On Thu, Jul 28, 2016 at 04:05:40PM -0400, Sheng-Hui J. Chu wrote:
> BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO
> IC.
> 
> To support BCM920706V2_EVAL dev board for WICED development on Linux.  Add
> the VID(0a5c) and 
> PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board.
> 
> Signed-off-by: Sheng-Hui J. Chu <s.jeffrey.chu@gmail.com>
> ---
>  drivers/usb/serial/ftdi_sio.c	   | 1 +
>  drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 0082080..ef19af4 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1008,6 +1008,7 @@ static const struct usb_device_id id_table_combined[]
> = {
> 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) },
> 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) },
> 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) },
> +	{ USB_DEVICE(WICED_USB_VID, WICED_USB20706V2_PID) },
> 	{ }					/* Terminating entry */
>  };
>  
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h
> b/drivers/usb/serial/ftdi_sio_ids.h
> index c5d6c1e..b29f280 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -1485,3 +1485,11 @@
>  #define CHETCO_SEASMART_DISPLAY_PID	0xA5AD /* SeaSmart NMEA2000 Display
> */
>  #define CHETCO_SEASMART_LITE_PID	0xA5AE /* SeaSmart Lite USB Adapter
> */

Ah, so close!

You have the whitespace issues fixed, but your patch is now line-wrapped :(

5th try?

thanks,

greg k-h

      reply	other threads:[~2016-07-28 20:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 20:05 [PATCH v4] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board Sheng-Hui J. Chu
2016-07-28 20:30 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160728203024.GA1382@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=s.jeffrey.chu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).