From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757695AbcG1UvI (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Jul 2016 16:51:08 -0400
Received: from mail-pf0-f193.google.com ([209.85.192.193]:33835 "EHLO
	mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751368AbcG1UvG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Jul 2016 16:51:06 -0400
Date: Thu, 28 Jul 2016 13:51:08 -0700
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: broonie@kernel.org, mark.rutland@arm.com, oder_chiou@realtek.com,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        lgirdwood@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        bardliao@realtek.com
Subject: Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls
Message-ID: <20160728205107.GA6804@Asurada-Nvidia>
References: <1469660568-3511-1-git-send-email-nicoleotsuka@gmail.com>
 <579A6DCC.6060401@metafoo.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <579A6DCC.6060401@metafoo.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 28, 2016 at 10:40:44PM +0200, Lars-Peter Clausen wrote:
> > +	/* Check if MCLK provided */
> > +	rt5659->mclk = devm_clk_get(&i2c->dev, "mclk");
> > +	if (IS_ERR(rt5659->mclk)) {
> > +		if (PTR_ERR(rt5659->mclk) == -EPROBE_DEFER)
> > +			return -EPROBE_DEFER;
> 
> The correct thing to do here is to check if != -ENOENT and then return
> the error code. Otherwise you silently ignore errors if a clock was
> specified, but there was an error requesting it.

Oh..Thanks for the input. Will refine it in v2.