linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Keith Busch <keith.busch@intel.com>
Cc: <linux-kernel@vger.kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	<linux-pci@vger.kernel.org>
Subject: Re: [PATCH -next] PCI/PCIe: make DPC explicitly non-modular
Date: Thu, 28 Jul 2016 17:28:02 -0400	[thread overview]
Message-ID: <20160728212801.GY11410@windriver.com> (raw)
In-Reply-To: <20160728202859.GA2420@localhost.localdomain>

[Re: [PATCH -next] PCI/PCIe: make DPC explicitly non-modular] On 28/07/2016 (Thu 16:29) Keith Busch wrote:

> On Thu, Jul 28, 2016 at 03:33:03PM -0400, Paul Gortmaker wrote:
> > The Kconfig currently controlling compilation of this code is:
> > 
> > drivers/pci/pcie/Kconfig:config PCIE_DPC
> > drivers/pci/pcie/Kconfig:       bool "PCIe Downstream Port Containment support"
> > 
> > ...meaning that it currently is not being built as a module by anyone.
> > 
> > Lets remove the modular code that is essentially orphaned, so that
> > when reading the driver there is no doubt it is builtin-only.
> > 
> > Since module_init translates to device_initcall in the non-modular
> > case, the init ordering remains unchanged with this commit.
> > 
> > We also delete the MODULE_LICENSE tag etc. since all that information
> > was (or is now) contained at the top of the file in the comments.
> 
> Thanks for cleaning this up.
> 
> FWIW, all of the other pcie service drivers look like they could use
> the same cleanup.

Yep, not to worry, I've still got the following patches pending for-4.9:

$ grep PCI series 
# PCI
PCI-aerdrv-make-it-explicitly-non-modular.patch
PCI-altera-make-it-explicitly-non-modular.patch
PCI-dra7xx-make-it-explicitly-non-modular.patch
PCI-imx6-make-it-explicitly-non-modular.patch
PCI-pme-make-it-explicitly-non-modular.patch
PCI-qcom-make-it-explicitly-non-modular.patch
PCI-spear13xx-make-it-explicitly-non-modular.patch
PCI-xilinx-make-it-explicitly-non-modular.patch
PCI-xilinx-nwl-make-it-eplicitly-non-modular.patch
PCI-portdrv-make-it-explicitly-non-modular.patch
PCI-PCIe-make-dpc-explicitly-non-modular.patch
PCI-generic-make-host-common-explicitly-non-modular.patch
PCI-hotplug_core-make-it-explicitly-non-modular.patch
PCI-hotplug-make-core-code-explicitly-non-modular.patch

Thanks,
Paul.
--

> 
> Reviewed-by: Keith Busch <keith.busch@intel.com>

  reply	other threads:[~2016-07-28 21:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 19:33 [PATCH -next] PCI/PCIe: make DPC explicitly non-modular Paul Gortmaker
2016-07-28 20:29 ` Keith Busch
2016-07-28 21:28   ` Paul Gortmaker [this message]
2016-08-22 19:44     ` Bjorn Helgaas
2016-08-22 22:12       ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160728212801.GY11410@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=bhelgaas@google.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).