From: Will Deacon <will.deacon@arm.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: william.c.roberts@intel.com, Yann Droneaud <ydroneaud@opteya.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com, linux@arm.linux.org.uk,
akpm@linux-foundation.org, keescook@chromium.org, tytso@mit.edu,
arnd@arndb.de, gregkh@linuxfoundation.org,
catalin.marinas@arm.com, ralf@linux-mips.org,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, viro@zeniv.linux.org.uk,
nnk@google.com, jeffv@google.com, dcashman@android.com
Subject: Re: [PATCH 4/7] arm64: Use simpler API for random address requests
Date: Fri, 29 Jul 2016 14:48:05 +0100 [thread overview]
Message-ID: <20160729134804.GJ16593@arm.com> (raw)
In-Reply-To: <20160728204730.27453-5-jason@lakedaemon.net>
On Thu, Jul 28, 2016 at 08:47:27PM +0000, Jason Cooper wrote:
> Currently, all callers to randomize_range() set the length to 0 and
> calculate end by adding a constant to the start address. We can
> simplify the API to remove a bunch of needless checks and variables.
>
> Use the new randomize_addr(start, range) call to set the requested
> address.
>
> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> ---
> arch/arm64/kernel/process.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
> index 6cd2612236dc..11bf454baf86 100644
> --- a/arch/arm64/kernel/process.c
> +++ b/arch/arm64/kernel/process.c
> @@ -374,12 +374,8 @@ unsigned long arch_align_stack(unsigned long sp)
>
> unsigned long arch_randomize_brk(struct mm_struct *mm)
> {
> - unsigned long range_end = mm->brk;
> -
> if (is_compat_task())
> - range_end += 0x02000000;
> + return randomize_addr(mm->brk, 0x02000000);
> else
> - range_end += 0x40000000;
> -
> - return randomize_range(mm->brk, range_end, 0) ? : mm->brk;
> + return randomize_addr(mm->brk, 0x40000000);
Looks fine to me, once the core code has settled down:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2016-07-29 13:48 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 20:47 [PATCH 0/7] char/random: Simplify random address requests Jason Cooper
2016-07-28 20:47 ` [PATCH 1/7] random: Simplify API for " Jason Cooper
2016-07-29 8:59 ` Yann Droneaud
2016-07-29 18:20 ` Jason Cooper
2016-07-28 20:47 ` [PATCH 2/7] x86: Use simpler " Jason Cooper
2016-07-28 20:47 ` [PATCH 3/7] ARM: " Jason Cooper
2016-07-28 20:47 ` [PATCH 4/7] arm64: " Jason Cooper
2016-07-29 13:48 ` Will Deacon [this message]
2016-07-28 20:47 ` [PATCH 5/7] tile: " Jason Cooper
2016-07-28 20:47 ` [PATCH 6/7] unicore32: " Jason Cooper
2016-07-28 20:47 ` [PATCH 7/7] random: Remove unused randomize_range() Jason Cooper
2016-07-30 15:42 ` [PATCH v2 0/7] char/random: Simplify random address requests Jason Cooper
2016-07-30 15:42 ` [PATCH v2 1/7] random: Simplify API for " Jason Cooper
2016-07-31 16:46 ` Kees Cook
2016-07-31 20:56 ` Jason Cooper
2016-08-01 19:47 ` Kees Cook
2016-08-01 23:17 ` Jason Cooper
2016-08-02 3:35 ` [kernel-hardening] " Michael Ellerman
2016-08-03 18:42 ` Jason Cooper
2016-07-30 15:42 ` [PATCH v2 2/7] x86: Use simpler " Jason Cooper
2016-07-30 15:42 ` [PATCH v2 3/7] ARM: " Jason Cooper
2016-07-30 15:42 ` [PATCH v2 4/7] arm64: " Jason Cooper
2016-07-30 15:42 ` [PATCH v2 5/7] tile: " Jason Cooper
2016-07-30 15:42 ` [PATCH v2 6/7] unicore32: " Jason Cooper
2016-07-30 15:42 ` [PATCH v2 7/7] random: Remove unused randomize_range() Jason Cooper
2016-08-03 23:39 ` [PATCH v3 0/7] char/random: Simplify random address requests Jason Cooper
2016-08-03 23:39 ` [PATCH v3 1/7] random: Simplify API for " Jason Cooper
2016-08-04 12:47 ` Yann Droneaud
2016-08-03 23:39 ` [PATCH v3 2/7] x86: Use simpler " Jason Cooper
2016-08-03 23:39 ` [PATCH v3 3/7] ARM: " Jason Cooper
2016-08-03 23:39 ` [PATCH v3 4/7] arm64: " Jason Cooper
2016-08-03 23:39 ` [PATCH v3 5/7] tile: " Jason Cooper
2016-08-03 23:39 ` [PATCH v3 6/7] unicore32: " Jason Cooper
2016-08-03 23:39 ` [PATCH v3 7/7] random: Remove unused randomize_range() Jason Cooper
2016-08-03 23:48 ` Andrew Morton
2016-08-04 0:19 ` Jason Cooper
2016-08-04 2:41 ` [PATCH v3 0/7] char/random: Simplify random address requests Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160729134804.GJ16593@arm.com \
--to=will.deacon@arm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=dcashman@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=jeffv@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=nnk@google.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=william.c.roberts@intel.com \
--cc=x86@kernel.org \
--cc=ydroneaud@opteya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).