From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751718AbcG2XC4 (ORCPT ); Fri, 29 Jul 2016 19:02:56 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41167 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751773AbcG2XCs (ORCPT ); Fri, 29 Jul 2016 19:02:48 -0400 Date: Fri, 29 Jul 2016 16:02:47 -0700 From: Andrew Morton To: zhongjiang Cc: , Subject: Re: [PATCH] fs: wipe off the compiler warn Message-Id: <20160729160247.564e27525f04416ef714ddd4@linux-foundation.org> In-Reply-To: <1469803600-44293-1-git-send-email-zhongjiang@huawei.com> References: <1469803600-44293-1-git-send-email-zhongjiang@huawei.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jul 2016 22:46:39 +0800 zhongjiang wrote: > From: zhong jiang > > when compile the kenrel code, I happens to the following warn. > fs/reiserfs/ibalance.c:1156:2: warning: ___new_insert_key___ may be used > uninitialized in this function. > memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE); > ^ > The patch just fix it to avoid the warn. > > Signed-off-by: zhong jiang > --- > fs/reiserfs/ibalance.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/reiserfs/ibalance.c b/fs/reiserfs/ibalance.c > index b751eea..512ce95 100644 > --- a/fs/reiserfs/ibalance.c > +++ b/fs/reiserfs/ibalance.c > @@ -818,7 +818,7 @@ int balance_internal(struct tree_balance *tb, > int order; > int insert_num, n, k; > struct buffer_head *S_new; > - struct item_head new_insert_key; > + struct item_head uninitialized_var(new_insert_key); > struct buffer_head *new_insert_ptr = NULL; > struct item_head *new_insert_key_addr = insert_key; How do we know this isn't a real bug? It isn't obvious to me that this warning is a false positive.