On Fri, Jul 29, 2016 at 04:46:43PM +0200, Maarten ter Huurne wrote: > for (count = 0, i = 0; i < map->num_reg_defaults_raw; i++) > - if (!regmap_volatile(map, i * map->reg_stride)) > + if (regmap_readable(map, i * map->reg_stride) && > + !regmap_volatile(map, i * map->reg_stride)) This seems fine but please use a normal coding style, there's a *huge* amount of indentation on the second line for some reason. It should align with the ( in the if statement.