From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753471AbcG2SMs (ORCPT ); Fri, 29 Jul 2016 14:12:48 -0400 Received: from down.free-electrons.com ([37.187.137.238]:50718 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751695AbcG2SMp (ORCPT ); Fri, 29 Jul 2016 14:12:45 -0400 Date: Fri, 29 Jul 2016 20:12:32 +0200 From: Maxime Ripard To: LABBE Corentin Cc: robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, davem@davemloft.net, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac Message-ID: <20160729181232.GF6215@lukather> References: <1469001800-11615-1-git-send-email-clabbe.montjoie@gmail.com> <1469001800-11615-4-git-send-email-clabbe.montjoie@gmail.com> <20160721075519.GC5993@lukather> <20160728134031.GC7582@Red> <20160728184916.GF6682@lukather> <20160729081519.GA31878@Red> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hK8Uo4Yp55NZU70L" Content-Disposition: inline In-Reply-To: <20160729081519.GA31878@Red> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hK8Uo4Yp55NZU70L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 29, 2016 at 10:15:19AM +0200, LABBE Corentin wrote: > > > > > +See ethernet.txt in the same directory for generic bindings for = ethernet > > > > > +controllers. > > > > > + > > > > > +The device node referenced by "phy" or "phy-handle" should be a = child node > > > > > +of this node. See phy.txt for the generic PHY bindings. > > > > > + > > > > > +Optional properties: > > > > > +- phy-supply: phandle to a regulator if the PHY needs one > > > > > +- phy-io-supply: phandle to a regulator if the PHY needs a anoth= er one for I/O. > > > > > + This is sometimes found with RGMII PHYs, which use a second > > > > > + regulator for the lower I/O voltage. > > > > > +- allwinner,tx-delay: The setting of the TX clock delay chain > > > > > +- allwinner,rx-delay: The setting of the RX clock delay chain > > > >=20 > > > > In which unit? What is the default value? > > >=20 > > > The unit is unknown to me, but I have added a comment for the > > > default and acceptable range value. > >=20 > > That's unfortunate. We'll see how the DT maintainers feel about that. > >=20 >=20 > I have searched for txdelay in Documentation, and found a few driver > that give the units (us/ps). > > But in that case, the value in ps/us must be found in a table > indexed by the Xxdelay value. > > So the settings seems always a raw number, and for sun8i-emac > nothing in user manual could help to find what each value is/related > to. >=20 > So the good value is either found by "try and test" or "copy the > value found in fex file". What I meant was that, just like you found out already, most of the time the properties should be in absolute units, so that it doesn't depend on some clock rate most likely in that case. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --hK8Uo4Yp55NZU70L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXm5yQAAoJEBx+YmzsjxAglS4P/2s5Tub25VgXdQ9JIj62udsi 1XvnAPwOK+GIBc+kXPghP2UMn4cpF7PFVe9pP1Mcy5bqCSE+mha4pmhz2PoI28Aa 5Bzeju9f2+16Dh9WvWQL0iFd1HjDXaltOFJotNcuGpWsUtZmu1znT/VFGmYD/fRZ kIuEvF5/wGa9V1Ax805Nll8E3gCaM6Ul2LEPMp/hO79E3hWAHJVNuNesZXkxQjFn BUuR8lhvCGivgM8K7RNdwMmWTZDjf9qAZQRhbwN+mMw0VGL8Js5SvbIHaeRbzKuL d4nZ/hkLyI9TYZEm3L2AISbSICVYSvsawbs4QC9k+vjWssx824CfOQNXcMjbleNn B6BgRKkgDpJubJUlfNvJVY1Yeaou8P09rh4rLpvIx223sZub6uvR3PBX6odXQkzF yPBsJsSmFgSbR1s1E1Ifd+YxU/0bTF4vRkx45AoMhaAQQVsFZi4i4/PjE11R+Rqb p3uaqCBCZPxx5htBOuDaymvTO71jiDI/8N2z20fKYA7qwaAmfiI46SiGe6ZGZLc4 /GgqWKkjqDbJWUGFm/1SuAqZL7nM14/yInA6leKune9I6f4K64i6EnV0qWkd1w0K immJqRmFFenazw9aVAZXoR9R61Ss0f33mS70KToXyWbjn8SwvfTDDKQd4w4kxCA+ YIeHUJoqZkZ3hU8b7qLv =Bis/ -----END PGP SIGNATURE----- --hK8Uo4Yp55NZU70L--