From: Rob Herring <robh@kernel.org>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Pawel Moll <pawel.moll@arm.com>, Mark Brown <broonie@kernel.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 7/7] doc: bindings: act8945a-charger: Update properties
Date: Fri, 29 Jul 2016 16:40:20 -0500 [thread overview]
Message-ID: <20160729214020.GA18140@rob-hp-laptop> (raw)
In-Reply-To: <1469755528-8413-8-git-send-email-wenyou.yang@atmel.com>
On Fri, Jul 29, 2016 at 09:25:28AM +0800, Wenyou Yang wrote:
> Due the driver improvements, update the properties,
> - Remove "active-semi,check-battery-temperature" property.
> - Add the properties, "active-semi,irq_gpio"
> and "active-semi,lbo-gpios".
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
> Changes in v3: None
> Changes in v2: None
>
> Documentation/devicetree/bindings/power/act8945a-charger.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/act8945a-charger.txt b/Documentation/devicetree/bindings/power/act8945a-charger.txt
> index bea254c..d7cf05b 100644
> --- a/Documentation/devicetree/bindings/power/act8945a-charger.txt
> +++ b/Documentation/devicetree/bindings/power/act8945a-charger.txt
> @@ -4,10 +4,12 @@ Required properties:
> - compatible: "active-semi,act8945a", please refer to ../mfd/act8945a.txt.
> - active-semi,chglev-gpios: charge current level phandle with args
> as described in ../gpio/gpio.txt.
> + - active-semi,irq_gpios: specify the charger interrupt input phanle
> + with args as as described in ../gpio/gpio.txt.
As I said in v2, this should be an interrupt property instead.
> + - active-semi,lbo-gpios: specify the low battery voltage detect phandle
> + with args as as described in ../gpio/gpio.txt.
Maybe this one too.
>
> Optional properties:
> - - active-semi,check-battery-temperature: boolean to check the battery
> - temperature or not.
> - active-semi,input-voltage-threshold-microvolt: unit: mV;
> Specifies the charger's input over-voltage threshold value;
> The value can be: 6600, 7000, 7500, 8000; default: 6600
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-07-29 21:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 1:25 [PATCH v3 0/7] power: act8945a_charger: Improvements Wenyou Yang
2016-07-29 1:25 ` [PATCH v3 1/7] power: act8945a_charger: Remove "battery_temperature" Wenyou Yang
2016-07-29 1:25 ` [PATCH v3 2/7] power: act8945a_charger: Improve Wenyou Yang
2016-07-29 1:25 ` [PATCH v3 3/7] power: act8945a_charger: Add status change update support Wenyou Yang
2016-07-29 1:25 ` [PATCH v3 4/7] power: act8945a_charger: Fix the power supply type Wenyou Yang
2016-07-29 1:25 ` [PATCH v3 5/7] power: act8945a_charger: Add capacity level property Wenyou Yang
2016-07-29 1:25 ` [PATCH v3 6/7] power: act8945a_charger: Add max current property Wenyou Yang
2016-07-29 1:25 ` [PATCH v3 7/7] doc: bindings: act8945a-charger: Update properties Wenyou Yang
2016-07-29 21:40 ` Rob Herring [this message]
2016-08-08 6:05 ` Wenyou.Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160729214020.GA18140@rob-hp-laptop \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=sre@kernel.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).