From: Leon Romanovsky <leonro@mellanox.com>
To: Tejun Heo <tj@kernel.org>
Cc: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
Matan Barak <matanb@mellanox.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue
Date: Sun, 31 Jul 2016 09:35:13 +0300 [thread overview]
Message-ID: <20160731063513.GW4628@leon.nu> (raw)
In-Reply-To: <20160729122237.GG2542@mtj.duckdns.org>
[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]
On Fri, Jul 29, 2016 at 08:22:37AM -0400, Tejun Heo wrote:
> Hello,
>
> On Thu, Jul 28, 2016 at 12:37:35PM +0300, Leon Romanovsky wrote:
> > Did you test this patch? Did you notice the memory reclaim path nature
> > of this work?
>
> The conversion uses WQ_MEM_RECLAIM, which is standard for all
> workqueues which can stall packet processing if stalled. The
> requirement comes from nfs or block devices over network.
The title stays "remove deprecated create_singlethread_workqueue" and if
we put aside the word "deprecated", the code moves from ordered
workqueue to unordered workqueue and changes max_active count which
isn't expressed in commit message.
For reclaim paths, I want to be extra caution and want to see
justification for doing that along with understanding if it is tested or
not.
Right now, I'm feeling that I'm participating in soapie where one sends
patch for every line, waits and sends the same patch for another file.
It is worth to send one patch set and let us to test it all in once.
Thanks.
>
> Thanks.
>
> --
> tejun
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-31 6:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 8:19 [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar
2016-07-28 9:37 ` Leon Romanovsky
2016-07-28 22:45 ` Saeed Mahameed
2016-07-29 12:22 ` Tejun Heo
2016-07-31 6:35 ` Leon Romanovsky [this message]
2016-08-01 15:11 ` Tejun Heo
2016-08-02 5:56 ` Leon Romanovsky
2016-07-28 22:44 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160731063513.GW4628@leon.nu \
--to=leonro@mellanox.com \
--cc=bhaktipriya96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).