From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755423AbcHAXoE (ORCPT ); Mon, 1 Aug 2016 19:44:04 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33310 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754488AbcHAXnz (ORCPT ); Mon, 1 Aug 2016 19:43:55 -0400 From: Kevin Hilman To: Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, Sekhar Nori , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Date: Mon, 1 Aug 2016 16:36:08 -0700 Message-Id: <20160801233610.10479-1-khilman@baylibre.com> X-Mailer: git-send-email 2.9.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org An ASoC driver using simple-card, when built as a module gets the following error at module load time: [ 23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0) [ 23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0) fix this by including simple-card-utils.o symbols in the module build its symols are resolved correctly. Tested on Davinci DA850-EVM using snd_soc_edma, snc_soc_davinci_mcasp, with all of ASoC built as modules. Cc: Sekhar Nori Signed-off-by: Kevin Hilman --- sound/soc/generic/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/generic/Makefile b/sound/soc/generic/Makefile index 45602ca8536e..ff0c55eee4f7 100644 --- a/sound/soc/generic/Makefile +++ b/sound/soc/generic/Makefile @@ -2,4 +2,8 @@ obj-$(CONFIG_SND_SIMPLE_CARD_UTILS) := simple-card-utils.o snd-soc-simple-card-objs := simple-card.o +ifneq ($(CONFIG_SND_SIMPLE_CARD_UTILS),) +snd-soc-simple-card-objs += simple-card-utils.o +endif + obj-$(CONFIG_SND_SIMPLE_CARD) += snd-soc-simple-card.o -- 2.9.0