From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933548AbcHBDqY (ORCPT ); Mon, 1 Aug 2016 23:46:24 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:32894 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933480AbcHBDqM (ORCPT ); Mon, 1 Aug 2016 23:46:12 -0400 Date: Tue, 2 Aug 2016 11:32:15 +0800 From: Peter Chen To: Matthias Kaehlcke Cc: Peter Chen , gregkh@linuxfoundation.org, stern@rowland.harvard.edu, ulf.hansson@linaro.org, broonie@kernel.org, sre@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org, k.kozlowski@samsung.com, linux-arm-kernel@lists.infradead.org, p.zabel@pengutronix.de, devicetree@vger.kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, linux-usb@vger.kernel.org, arnd@arndb.de, s.hauer@pengutronix.de, mail@maciej.szmigiero.name, troy.kisky@boundarydevices.com, festevam@gmail.com, oscar@naiandei.net, stephen.boyd@linaro.org, linux-pm@vger.kernel.org, stillcompiling@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [v3,2/6] power: add power sequence library Message-ID: <20160802033215.GB26831@shlinux2> References: <1469007629-31757-3-git-send-email-peter.chen@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 29, 2016 at 01:06:48PM -0700, Matthias Kaehlcke wrote: > >... > > > >+static int pwrseq_generic_get(struct device_node *np, struct pwrseq *pwrseq) > >+{ > >+ struct pwrseq_generic *pwrseq_gen = to_generic_pwrseq(pwrseq); > >+ enum of_gpio_flags flags; > >+ int reset_gpio, ret = 0; > >+ > >+ pwrseq_gen->clk = of_clk_get_by_name(np, NULL); > This only gets the first of potentially multiple clocks, is that intended? Matthias, I have added multiple input clocks support at v4 patch set, and you are at cc list. -- Best Regards, Peter Chen