From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936179AbcHBSMv (ORCPT ); Tue, 2 Aug 2016 14:12:51 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54096 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932179AbcHBSLg (ORCPT ); Tue, 2 Aug 2016 14:11:36 -0400 Date: Tue, 2 Aug 2016 19:11:14 +0100 From: Mark Brown To: Kuninori Morimoto Cc: Kevin Hilman , Liam Girdwood , alsa-devel@alsa-project.org, Sekhar Nori , Jaroslav Kysela , Takashi Iwai , open list Message-ID: <20160802181114.GG10376@sirena.org.uk> References: <20160801233610.10479-1-khilman@baylibre.com> <877fc0hte3.wl%kuninori.morimoto.gx@renesas.com> <8760rjj20g.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LNKrWK8T5LDJo+fl" Content-Disposition: inline In-Reply-To: <8760rjj20g.wl%kuninori.morimoto.gx@renesas.com> X-Cookie: Tell me what to think!!! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LNKrWK8T5LDJo+fl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 02, 2016 at 03:22:08AM +0000, Kuninori Morimoto wrote: > +MODULE_AUTHOR("Kuninori Morimoto "); > +MODULE_DESCRIPTION("ALSA SoC Simple Card Utils"); > +MODULE_LICENSE("GPL v2"); This lot is what is needed (well, just the MODULE_LICENSE). > +MODULE_ALIAS("platform:asoc-simple-card-utils"); This is wrong, this isn't a driver but rather a library that's used by other modules so it shouldn't have an alias. The aliases are there to let modutils know which module to load for a device that it sees. --LNKrWK8T5LDJo+fl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXoOJBAAoJECTWi3JdVIfQ4EgH/0U85U9z5Es3porYH6spltCw pPyhZkxcEQWFr6x/oJWLCl2uLGuUdZ1Lb2cCJo+vgir7EwjO1tsvv8EikCbEnlhc eKBv82IteGSKpZcmCLUcrmUKcyclinty4bDnYMdgR5zabIY3gi6TTx4x0GgAnbYY 5qlDzaITHTHjXxd/vBrXeCJXoV6gT9f14H0nt/vNyIMh9HCb208lC1hW5A/J5qUD zuhQdt+l0vwyeQBJBLzteMS0Lq59j704KpV2drn6oXFRPoX015NHLOEDTLcfdzhA Dh9TjvIFRYyRSVnoh+cOq2K/kFU4IW7aMIuEUijOy6AiFLCkR3THLn56cl2hqug= =iZcW -----END PGP SIGNATURE----- --LNKrWK8T5LDJo+fl--