From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757382AbcHBTmm (ORCPT ); Tue, 2 Aug 2016 15:42:42 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54590 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756646AbcHBTmW (ORCPT ); Tue, 2 Aug 2016 15:42:22 -0400 Date: Tue, 2 Aug 2016 20:41:46 +0100 From: Mark Brown To: Kevin Hilman Cc: Kuninori Morimoto , Liam Girdwood , alsa-devel@alsa-project.org, Sekhar Nori , Jaroslav Kysela , Takashi Iwai , open list Message-ID: <20160802194146.GI10376@sirena.org.uk> References: <20160801233610.10479-1-khilman@baylibre.com> <877fc0hte3.wl%kuninori.morimoto.gx@renesas.com> <8760rjj20g.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1QGDfz3Tkbtkncdd" Content-Disposition: inline In-Reply-To: X-Cookie: Tell me what to think!!! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1QGDfz3Tkbtkncdd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 02, 2016 at 11:50:48AM -0700, Kevin Hilman wrote: > Your patch works, but as Mark pointed out, I didn't think that this was > the right fix as this isn't a module, but just library. I think building the library as a module is fine, that way we can load it only in situations where it's used, it's just that it should be pulled in by the relevant driver. --1QGDfz3Tkbtkncdd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXoPd6AAoJECTWi3JdVIfQGEQH/38CW5me21biwIM07aA1LI83 1XFWw2jyEflgsbxaa3ibl/jY0igELJzFLM3ShMWvAZAmK/G4RGdWIpKl40kqzc2k ATQVknSDBdcGF8Kb7qdIeAMUnkKUx6cDbIFLHL2bkcGES+gZA+cfduSZmWQWsiiW 99HONYr1cMvAB/YV46Tt1zJx2OfISULOcxFAMzmLFRi7G4Zk8t8plc/7P8YGLL4z gAfQYoi1spU1WEKo6I0fCtgs8exWlwRzSsyssB/k6SZwB5wTwDDY7K+kYjTa6z8V 71uSXxDZOIIXu0qSSStDM7Xfr17kg5j5nWrpoa3WCLt9dtpRLi3QdpdDIPDDA/E= =WH7b -----END PGP SIGNATURE----- --1QGDfz3Tkbtkncdd--