From: Steve Cotton <steve@s.cotton.clara.co.uk>
To: Baole Ni <baolex.ni@intel.com>
Cc: Mauro Carvalho Chehab <maurochehab@gmail.com>,
gregkh@linuxfoundation.org, m.szyprowski@samsung.com,
kyungmin.park@samsung.com, k.kozlowski@samsung.com,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, amitoj1606@gmail.com,
arnd@arndb.de, hverkuil@xs4all.nl, chuansheng.liu@intel.com
Subject: Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 21:56:29 +0200 [thread overview]
Message-ID: <20160802195629.ojiw5vph4y2lgjup@s.cotton.clara.co.uk> (raw)
In-Reply-To: <20160802095118.47dcc5a6@recife.lan>
On Tue, Aug 02, 2016 at 09:51:18AM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 2 Aug 2016 20:01:34 +0800 Baole Ni <baolex.ni@intel.com> escreveu:
>
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
>
> Gah!
>
> A patch series with 1285 patches with identical subject!
>
> Please don't ever do something like that. My inbox is not trash!
>
> Instead, please group the changes per subsystem, and use different
> names for each patch. Makes easier for people to review.
Hi Baole,
It may also be worth waiting for the first group to be reviewed before
sending the other groups, in case the review comments change what you
send later.
> > -module_param(sg_mode, bool, 0644);
> > +module_param(sg_mode, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
There's an S_IRUGO macro which makes the above just 'S_IRUGO | S_IWUSR'.
Regards,
Steve
prev parent reply other threads:[~2016-08-02 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 12:01 [PATCH 0947/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 12:51 ` Mauro Carvalho Chehab
2016-08-02 15:00 ` Randy Dunlap
2016-08-02 19:56 ` Steve Cotton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802195629.ojiw5vph4y2lgjup@s.cotton.clara.co.uk \
--to=steve@s.cotton.clara.co.uk \
--cc=amitoj1606@gmail.com \
--cc=arnd@arndb.de \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maurochehab@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).