From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757207AbcHCCdV (ORCPT ); Tue, 2 Aug 2016 22:33:21 -0400 Received: from smtprelay0161.hostedemail.com ([216.40.44.161]:48112 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752199AbcHCCdN (ORCPT ); Tue, 2 Aug 2016 22:33:13 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::,RULES_HIT:41:355:379:421:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2904:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:5007:6261:6742:7875:7903:10004:10400:10848:10967:11026:11232:11658:11914:12296:12517:12519:12740:13069:13161:13229:13255:13311:13357:13439:14096:14097:14181:14659:14721:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: crush18_3c382ec22de3d X-Filterd-Recvd-Size: 2491 Date: Tue, 2 Aug 2016 22:30:11 -0400 From: Steven Rostedt To: Josh Poimboeuf Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Linus Torvalds , Brian Gerst , Kees Cook , Peter Zijlstra , Frederic Weisbecker , Byungchul Park Subject: Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues Message-ID: <20160802223011.6209e28c@grimm.local.home> In-Reply-To: <20160803015656.j6fxrgucmghh5gfn@treble> References: <20160729185521.62a5cd2a@gandalf.local.home> <20160730005059.5krpl2xsvqfbnntj@treble> <20160729222036.340b51ce@grimm.local.home> <20160730135125.qqw5qz24szlc2crz@treble> <20160801102821.1d6261a9@gandalf.local.home> <20160801153633.c7sa2rclkqwbdagd@treble> <20160802210011.k6li4mnyvky5jtev@treble> <20160802171610.09156c90@gandalf.local.home> <20160802221359.tkb3mkjzkq3petrq@treble> <20160802191622.466f53d2@gandalf.local.home> <20160803015656.j6fxrgucmghh5gfn@treble> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Aug 2016 20:56:56 -0500 Josh Poimboeuf wrote: > It's not specific to NMIs. The problem is that dump_trace() is starting > from the frame pointed to by a pt_regs, rather than the current frame. > Instead of starting with the current frame, the first 10 functions on > the stack are skipped by the unwinder, but they're *not* skipped on the > ret_stack. So it starts out out-of-sync. OK, I see what you mean. If we do a dumpstack from interrupt passing in the pt_regs of the kernel thread that was interrupted, even though functions up to the interrupt was called and traced, which will show up in the dump stack that shouldn't. OK, you convinced me. Add the extra pointer, then we will have 4 longs and 2 long longs in ftrace_ret_stack. That's not that bad. -- Steve