From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933906AbcHDO3t (ORCPT ); Thu, 4 Aug 2016 10:29:49 -0400 Received: from muru.com ([72.249.23.125]:45026 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758617AbcHDO3g (ORCPT ); Thu, 4 Aug 2016 10:29:36 -0400 Date: Thu, 4 Aug 2016 07:29:19 -0700 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: Andreas Kemnade , Bin Liu , Greg Kroah-Hartman , Linux USB Mailing List , linux-omap , LKML , Discussions about the Letux Kernel Subject: Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable() Message-ID: <20160804142919.GG28140@atomide.com> References: <1470238731-32358-1-git-send-email-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * H. Nikolaus Schaller [160803 10:07]: > All this prevents detection of cable plugin-events and VBUS measurement > and setting OTG_EN before charging is attempted. So I gave this patch a try but it now blocks all deeper SoC idle states as the PHY stays active. I think the real fix is to make sure the charger behaves independent of the USB PHY state. So probably this needs to be fixed in phy-twl4030-usb.c and twl4030_charger.c instead. Now it sounds like we're also shutting down the charger with the USB PHY. Regards, Tony