From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966108AbcHDU7i (ORCPT ); Thu, 4 Aug 2016 16:59:38 -0400 Received: from glaubenleben.de ([85.214.105.140]:55155 "EHLO glaubenleben.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965790AbcHDU7g (ORCPT ); Thu, 4 Aug 2016 16:59:36 -0400 Date: Thu, 4 Aug 2016 22:59:29 +0200 From: Andreas Kemnade To: "H. Nikolaus Schaller" Cc: Tony Lindgren , Bin Liu , Greg Kroah-Hartman , Linux USB Mailing List , linux-omap , LKML , Discussions about the Letux Kernel Subject: Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable() Message-ID: <20160804225929.33a94511@aktux> In-Reply-To: <3EF398D0-6B90-46B6-83AE-EAE065A68890@goldelico.com> References: <1470238731-32358-1-git-send-email-andreas@kemnade.info> <20160804142919.GG28140@atomide.com> <3EF398D0-6B90-46B6-83AE-EAE065A68890@goldelico.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Aug 2016 16:49:30 +0200 "H. Nikolaus Schaller" wrote: > > Rationale: > > > > The charger driver calls pm_runtime_get_sync(bci->transceiver->dev); > > which should indirectly call twl4030_usb_set_mode to set the > > POWER_CTRL_OTG_ENAB bit. This enables the prescaler hardware > > for ADC8 (VBUS) channel. But this does not happen for reasons > > outside the charger driver. > > how should that work? I only have seen the call trace from the musb/omap2430.c glue though the phy subsystem (via phy_ops) to twl4030_phy_power_on (which sets the important bit). And the phy subsystem has its own power refcounting system which is brought into disorder by unbalanced calls from the musb system... Regards, Andreas