linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Andy Gross <andy.gross@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 1/3] regulator: qcom_smd: Fix voltage ranges for pm8x41
Date: Thu, 4 Aug 2016 17:58:26 -0700	[thread overview]
Message-ID: <20160805005826.GD15690@codeaurora.org> (raw)
In-Reply-To: <20160711224845.GC6053@hector.attlocal.net>

On 07/11, Andy Gross wrote:
> On Mon, Jul 11, 2016 at 02:50:07PM -0700, Stephen Boyd wrote:
> 
> >  static const struct regulator_desc pm8941_pldo = {
> >  	.linear_ranges = (struct regulator_linear_range[]) {
> > -		REGULATOR_LINEAR_RANGE( 750000,  0,  30, 25000),
> > -		REGULATOR_LINEAR_RANGE(1500000, 31, 99, 50000),
> > +		REGULATOR_LINEAR_RANGE( 750000,  0,  63, 12500),
> > +		REGULATOR_LINEAR_RANGE(1550000, 64, 126, 25000),
> > +		REGULATOR_LINEAR_RANGE(3100000, 127, 163, 50000),
> >  	},
> > -	.n_linear_ranges = 2,
> > -	.n_voltages = 100,
> > +	.n_linear_ranges = 3,
> > +	.n_voltages = 164,
> >  	.ops = &rpm_smps_ldo_ops,
> >  };
> 
> Still a little confused on if the 12.5mV is allowed on pmos ldo.  It seems like the
> nmos has 1 range of 5mV steps.  The PMOS has 2 ranges, using 25mV and 50mV
> 

The values I've put in these patches are the correct ranges.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2016-08-05  0:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11 21:50 [PATCH 0/3] Fixes for RPM SMD regulator voltage ranges Stephen Boyd
2016-07-11 21:50 ` [PATCH 1/3] regulator: qcom_smd: Fix voltage ranges for pm8x41 Stephen Boyd
2016-07-11 22:48   ` Andy Gross
2016-08-05  0:58     ` Stephen Boyd [this message]
2016-08-05  4:09       ` Andy Gross
2016-08-05 12:09   ` Applied "regulator: qcom_smd: Fix voltage ranges for pm8x41" to the regulator tree Mark Brown
2016-08-13  4:00     ` Bjorn Andersson
2016-08-15 12:51       ` Mark Brown
2016-07-11 21:50 ` [PATCH 2/3] regulator: qcom_smd: Fix voltage ranges for pma8084 ftsmps and pldo Stephen Boyd
2016-07-11 22:38   ` Andy Gross
2016-08-05  0:57     ` Stephen Boyd
2016-08-05  4:09       ` Andy Gross
2016-08-05 12:09   ` Applied "regulator: qcom_smd: Fix voltage ranges for pma8084 ftsmps and pldo" to the regulator tree Mark Brown
2016-07-11 21:50 ` [PATCH 3/3] regulator: qcom_smd: Avoid overlapping linear voltage ranges Stephen Boyd
2016-07-11 22:39   ` Andy Gross
2016-07-12  9:02   ` Applied "regulator: qcom_smd: Avoid overlapping linear voltage ranges" to the regulator tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160805005826.GD15690@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).