From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161230AbcHELq7 (ORCPT ); Fri, 5 Aug 2016 07:46:59 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:38716 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759660AbcHELq5 (ORCPT ); Fri, 5 Aug 2016 07:46:57 -0400 Date: Fri, 5 Aug 2016 12:46:53 +0100 From: Matt Fleming To: Austin Christ Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jbrasen@codeaurora.org Subject: Re: [PATCH v2] efi: capsule: allocate whole capsule into virtual memory Message-ID: <20160805114653.GP3636@codeblueprint.co.uk> References: <1469741429-17606-1-git-send-email-austinwc@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469741429-17606-1-git-send-email-austinwc@codeaurora.org> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Jul, at 03:30:29PM, Christ, Austin wrote: > According to UEFI 2.6 section 7.5.3, the capsule should be in contiguous > virtual memory and firmware may consume the capsule immediately. To > correctly implement this functionality, the kernel driver needs to vmap > the entire capsule at the time it is made available to firmware. > > The virtual allocation of the capsule update has been changed from kmap, > which was only allocating the first page of the update, to vmap, and > allocates the entire data payload. > > Signed-off-by: Austin Christ > Reviewed-by: Matt Fleming > Reviewed-by: Lee, Chun-Yi > --- > drivers/firmware/efi/capsule-loader.c | 8 +++++--- > drivers/firmware/efi/capsule.c | 6 +++--- > 2 files changed, 8 insertions(+), 6 deletions(-) Thanks, applied.