From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752228AbcHHJNU (ORCPT ); Mon, 8 Aug 2016 05:13:20 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:35242 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbcHHJNS (ORCPT ); Mon, 8 Aug 2016 05:13:18 -0400 Date: Mon, 8 Aug 2016 10:14:43 +0100 From: Lee Jones To: Paul Gortmaker Cc: Laxman Dewangan , linux-kernel@vger.kernel.org, Samuel Ortiz , Florian Lobmaier Subject: Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular Message-ID: <20160808091443.GI5243@dell> References: <20160705012544.14143-1-paul.gortmaker@windriver.com> <20160705012544.14143-3-paul.gortmaker@windriver.com> <577B4A30.4050303@nvidia.com> <20160706164538.GI26134@windriver.com> <20160805125607.GZ5243@dell> <20160805135031.GO29630@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160805135031.GO29630@windriver.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 05 Aug 2016, Paul Gortmaker wrote: > [Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular] On 05/08/2016 (Fri 13:56) Lee Jones wrote: > > > On Wed, 06 Jul 2016, Paul Gortmaker wrote: > > > > > [Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular] On 05/07/2016 (Tue 11:18) Laxman Dewangan wrote: > > > > > > > > > > > On Tuesday 05 July 2016 06:55 AM, Paul Gortmaker wrote: > > > > >The Kconfig currently controlling compilation of this code is: > > > > > > > > > >drivers/mfd/Kconfig:config MFD_AS3722 > > > > >drivers/mfd/Kconfig: bool "ams AS3722 Power Management IC" > > > > > > > > > > > > > > > > > Should we convert this to as "tristate" so that it can be built as module > > > > also. > > > > > > Seems to compile and modpost w/o missing symbols as tristate: > > > > > > paul@yow-builder:~/git/linux-head$ ls -l ../arm-build/drivers/mfd/as3722* > > > -rw-rw-r-- 1 paul paul 13010 Jul 6 12:30 ../arm-build/drivers/mfd/as3722.ko > > > -rw-rw-r-- 1 paul paul 1937 Jul 6 12:28 ../arm-build/drivers/mfd/as3722.mod.c > > > -rw-rw-r-- 1 paul paul 3820 Jul 6 12:29 ../arm-build/drivers/mfd/as3722.mod.o > > > -rw-rw-r-- 1 paul paul 11292 Jul 6 12:13 ../arm-build/drivers/mfd/as3722.o > > > paul@yow-builder:~/git/linux-head$ > > > > > > ...so I'll drop this patch in favour of the one line tristate conversion in v2. > > > > Did you ever get around to submitting a v2? > > I made the v2 (as per above build stats) but never sent it out since I > wasn't sure if mfd wanted a complete resend (like davem/linux-net) or > just resends of the revised content... and then I never came back to it. > > Here is the one line trivial patch. If you want to punt this to 4.9 > given the current timing wrt. the merge window, feel free to do so; > and/or I can re-send it myself with other pending 4.9 content I have. >>From a personal PoV, I'd prefer if you just submitted patches normally. I'll field them when they land in my Inbox. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog