From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752360AbcHHLs6 (ORCPT ); Mon, 8 Aug 2016 07:48:58 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37449 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752127AbcHHLsy (ORCPT ); Mon, 8 Aug 2016 07:48:54 -0400 Date: Mon, 8 Aug 2016 12:50:19 +0100 From: Lee Jones To: Chen-Yu Tsai Cc: Alessandro Zummo , Alexandre Belloni , Maxime Ripard , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 1/7] mfd: ac100: Add device tree bindings for X-Powers AC100 codec/RTC combo IC Message-ID: <20160808115019.GL5243@dell> References: <1467988422-17934-1-git-send-email-wens@csie.org> <1467988422-17934-2-git-send-email-wens@csie.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1467988422-17934-2-git-send-email-wens@csie.org> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 08 Jul 2016, Chen-Yu Tsai wrote: > The AC100 is a multifunction device with an audio codec subsystem and > an RTC subsystem. These two subsystems share a common register space > and host interface. > > Signed-off-by: Chen-Yu Tsai > Acked-by: Rob Herring > --- > Changes since v4: > > - Style changes suggested by Lee. > - Added commit message. > - Added Rob's ack. > > Changes since v3: > > - Fixed device node names and added labels. > - Added clock output from codec and input to rtc. > > Changes since v2: > > - Fix interrupt line for ac100_codec in provided example. > > --- > Documentation/devicetree/bindings/mfd/ac100.txt | 54 +++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/ac100.txt For my own reference: Acked-by: Lee Jones > diff --git a/Documentation/devicetree/bindings/mfd/ac100.txt b/Documentation/devicetree/bindings/mfd/ac100.txt > new file mode 100644 > index 000000000000..b8ef00667599 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/ac100.txt > @@ -0,0 +1,54 @@ > +X-Powers AC100 Codec/RTC IC Device Tree bindings > + > +AC100 is a audio codec and RTC subsystem combo IC. The 2 parts are > +separated, including power supplies and interrupt lines, but share > +a common register address space and host interface. > + > +Required properties: > +- compatible: "x-powers,ac100" > +- reg: The I2C slave address or RSB hardware address for the chip > +- sub-nodes: > + - codec > + - compatible: "x-powers,ac100-codec" > + - interrupt-parent: The parent interrupt controller > + - interrupts: SoC NMI / GPIO interrupt connected to the > + IRQ_AUDIO pin > + - #clock-cells: Shall be 0 > + - clock-output-names: "4M_adda" > + > + - see clock/clock-bindings.txt for common clock bindings > + > + - rtc > + - compatible: "x-powers,ac100-rtc" > + - interrupt-parent: The parent interrupt controller > + - interrupts: SoC NMI / GPIO interrupt connected to the > + IRQ_RTC pin > + - clocks: A phandle to the codec's "4M_adda" clock > + - #clock-cells: Shall be 1 > + - clock-output-names: "cko1_rtc", "cko2_rtc", "cko3_rtc" > + > + - see clock/clock-bindings.txt for common clock bindings > + > +Example: > + > +ac100: codec@e89 { > + compatible = "x-powers,ac100"; > + reg = <0xe89>; > + > + ac100_codec: codec { > + compatible = "x-powers,ac100-codec"; > + interrupt-parent = <&r_pio>; > + interrupts = <0 9 IRQ_TYPE_LEVEL_LOW>; /* PL9 */ > + #clock-cells = <0>; > + clock-output-names = "4M_adda"; > + }; > + > + ac100_rtc: rtc { > + compatible = "x-powers,ac100-rtc"; > + interrupt-parent = <&nmi_intc>; > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&ac100_codec>; > + #clock-cells = <1>; > + clock-output-names = "cko1_rtc", "cko2_rtc", "cko3_rtc"; > + }; > +}; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog