From: Lee Jones <lee.jones@linaro.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/7] mfd: ac100: Add device tree bindings for X-Powers AC100 codec/RTC combo IC
Date: Mon, 8 Aug 2016 12:56:36 +0100 [thread overview]
Message-ID: <20160808115636.GN5243@dell> (raw)
In-Reply-To: <20160808115019.GL5243@dell>
On Mon, 08 Aug 2016, Lee Jones wrote:
> On Fri, 08 Jul 2016, Chen-Yu Tsai wrote:
>
> > The AC100 is a multifunction device with an audio codec subsystem and
> > an RTC subsystem. These two subsystems share a common register space
> > and host interface.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> > Changes since v4:
> >
> > - Style changes suggested by Lee.
> > - Added commit message.
> > - Added Rob's ack.
> >
> > Changes since v3:
> >
> > - Fixed device node names and added labels.
> > - Added clock output from codec and input to rtc.
> >
> > Changes since v2:
> >
> > - Fix interrupt line for ac100_codec in provided example.
> >
> > ---
> > Documentation/devicetree/bindings/mfd/ac100.txt | 54 +++++++++++++++++++++++++
> > 1 file changed, 54 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mfd/ac100.txt
>
> For my own reference:
> Acked-by: Lee Jones <lee.jones@linaro.org>
Applied, thanks.
> > diff --git a/Documentation/devicetree/bindings/mfd/ac100.txt b/Documentation/devicetree/bindings/mfd/ac100.txt
> > new file mode 100644
> > index 000000000000..b8ef00667599
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/ac100.txt
> > @@ -0,0 +1,54 @@
> > +X-Powers AC100 Codec/RTC IC Device Tree bindings
> > +
> > +AC100 is a audio codec and RTC subsystem combo IC. The 2 parts are
> > +separated, including power supplies and interrupt lines, but share
> > +a common register address space and host interface.
> > +
> > +Required properties:
> > +- compatible: "x-powers,ac100"
> > +- reg: The I2C slave address or RSB hardware address for the chip
> > +- sub-nodes:
> > + - codec
> > + - compatible: "x-powers,ac100-codec"
> > + - interrupt-parent: The parent interrupt controller
> > + - interrupts: SoC NMI / GPIO interrupt connected to the
> > + IRQ_AUDIO pin
> > + - #clock-cells: Shall be 0
> > + - clock-output-names: "4M_adda"
> > +
> > + - see clock/clock-bindings.txt for common clock bindings
> > +
> > + - rtc
> > + - compatible: "x-powers,ac100-rtc"
> > + - interrupt-parent: The parent interrupt controller
> > + - interrupts: SoC NMI / GPIO interrupt connected to the
> > + IRQ_RTC pin
> > + - clocks: A phandle to the codec's "4M_adda" clock
> > + - #clock-cells: Shall be 1
> > + - clock-output-names: "cko1_rtc", "cko2_rtc", "cko3_rtc"
> > +
> > + - see clock/clock-bindings.txt for common clock bindings
> > +
> > +Example:
> > +
> > +ac100: codec@e89 {
> > + compatible = "x-powers,ac100";
> > + reg = <0xe89>;
> > +
> > + ac100_codec: codec {
> > + compatible = "x-powers,ac100-codec";
> > + interrupt-parent = <&r_pio>;
> > + interrupts = <0 9 IRQ_TYPE_LEVEL_LOW>; /* PL9 */
> > + #clock-cells = <0>;
> > + clock-output-names = "4M_adda";
> > + };
> > +
> > + ac100_rtc: rtc {
> > + compatible = "x-powers,ac100-rtc";
> > + interrupt-parent = <&nmi_intc>;
> > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&ac100_codec>;
> > + #clock-cells = <1>;
> > + clock-output-names = "cko1_rtc", "cko2_rtc", "cko3_rtc";
> > + };
> > +};
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-08-08 11:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 14:33 [PATCH v5 0/7] mfd: ac100: Add support for X-Powers AC100 audio codec / RTC combo IC Chen-Yu Tsai
2016-07-08 14:33 ` [PATCH v5 1/7] mfd: ac100: Add device tree bindings for X-Powers AC100 codec/RTC " Chen-Yu Tsai
2016-08-08 11:50 ` Lee Jones
2016-08-08 11:56 ` Lee Jones [this message]
2016-07-08 14:33 ` [PATCH v5 2/7] mfd: ac100: Add driver for X-Powers AC100 audio codec / RTC " Chen-Yu Tsai
2016-08-08 11:56 ` Lee Jones
2016-07-08 14:33 ` [PATCH v5 3/7] rtc: ac100: Add RTC driver for X-Powers AC100 Chen-Yu Tsai
2016-07-08 16:21 ` Alexandre Belloni
2016-08-08 11:57 ` Lee Jones
2017-02-05 21:33 ` [v5,3/7] " Rask Ingemann Lambertsen
2017-02-06 3:29 ` Chen-Yu Tsai
2017-02-06 18:15 ` Rask Ingemann Lambertsen
2016-07-08 14:33 ` [PATCH v5 4/7] rtc: ac100: Add clk output support Chen-Yu Tsai
2016-07-08 16:29 ` Alexandre Belloni
2016-08-08 11:56 ` Lee Jones
2016-07-08 14:33 ` [PATCH v5 5/7] ARM: dts: sun9i: a80-optimus: Add device node for AC100 Chen-Yu Tsai
2016-07-08 14:33 ` [PATCH v5 6/7] ARM: dts: sun9i: cubieboard4: " Chen-Yu Tsai
2016-07-08 14:33 ` [PATCH v5 7/7] ARM: dts: sun9i: Switch to the AC100 RTC clock outputs for osc32k Chen-Yu Tsai
2016-07-11 6:50 ` Maxime Ripard
2016-07-12 2:02 ` Chen-Yu Tsai
2016-08-16 7:20 ` Chen-Yu Tsai
2016-08-08 12:01 ` [PATCH v5 0/7] mfd: ac100: Add support for X-Powers AC100 audio codec / RTC combo IC Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808115636.GN5243@dell \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=rtc-linux@googlegroups.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).