From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752549AbcHHNlj (ORCPT ); Mon, 8 Aug 2016 09:41:39 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36410 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752184AbcHHNlh (ORCPT ); Mon, 8 Aug 2016 09:41:37 -0400 Date: Mon, 8 Aug 2016 14:43:03 +0100 From: Lee Jones To: Tan Jui Nee Cc: mika.westerberg@linux.intel.com, heikki.krogerus@linux.intel.com, andriy.shevchenko@linux.intel.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, ptyser@xes-inc.com, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, jonathan.yong@intel.com, ong.hock.yu@intel.com, weifeng.voon@intel.com, wan.ahmad.zainie.wan.mohamad@intel.com Subject: Re: [PATCH v6 2/3] mfd: lpc_ich: Rename lpc-ich driver Message-ID: <20160808134303.GS5243@dell> References: <1468483919-31258-1-git-send-email-jui.nee.tan@intel.com> <1468483919-31258-3-git-send-email-jui.nee.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1468483919-31258-3-git-send-email-jui.nee.tan@intel.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jul 2016, Tan Jui Nee wrote: > This patch follows the example of mfd/wm831x to rename the driver > from "lpc_ich" to "lpc_ich-core". > > Signed-off-by: Tan Jui Nee > --- > Changes in V6: > - none, just a subject line and commit message change. > > drivers/mfd/Makefile | 1 + > drivers/mfd/{lpc_ich.c => lpc_ich-core.c} | 0 > 2 files changed, 1 insertion(+) > rename drivers/mfd/{lpc_ich.c => lpc_ich-core.c} (100%) Looks a bit odd. I suggest 'lpc_ich_core.c' instead. > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 42a66e1..1dfe5fb 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -155,6 +155,7 @@ obj-$(CONFIG_PMIC_ADP5520) += adp5520.o > obj-$(CONFIG_MFD_KEMPLD) += kempld-core.o > obj-$(CONFIG_MFD_INTEL_QUARK_I2C_GPIO) += intel_quark_i2c_gpio.o > obj-$(CONFIG_LPC_SCH) += lpc_sch.o > +lpc_ich-objs := lpc_ich-core.o > obj-$(CONFIG_LPC_ICH) += lpc_ich.o > obj-$(CONFIG_MFD_RDC321X) += rdc321x-southbridge.o > obj-$(CONFIG_MFD_JANZ_CMODIO) += janz-cmodio.o > diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich-core.c > similarity index 100% > rename from drivers/mfd/lpc_ich.c > rename to drivers/mfd/lpc_ich-core.c -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog