Re: [RFC PATCH 0/3] Add kconfig symbol as module attribute

From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Cristina Moraru <cristina.moraru09@gmail.com>
Cc: linux-kernel@vger.kernel.org, mcgrof@kernel.org, teg@jklm.no,
	kay@vrfy.org, rusty@rustcorp.com.au, akpm@linux-foundation.org
Subject: Re: [RFC PATCH 0/3] Add kconfig symbol as module attribute
Date: Mon, 8 Aug 2016 19:25:06 +0200	[thread overview]
Message-ID: <20160808172506.GQ3296@wotan.suse.de> (raw)
In-Reply-To: <1469979232-15531-1-git-send-email-cristina.moraru09@gmail.com>

On Sun, Jul 31, 2016 at 05:33:49PM +0200, Cristina Moraru wrote:
> This patchset implements dynamic pegging of kconfig symbol
> into driver modinfo section
> 
> * adds a kconfig symbol attribute to struct module
> * updates streamline_config.pl to generate the auxiliary file
> scripts/mod/Module.ksymb containing associations of driver file
> names and corresponding kconfig symbols CONFIG_*
> * updates modpost to use the information from Module.ksymb to
> add the content of the attribute kconfig_symbol.
> 
> Please note that this patchset is part of a research and
> currently does not provide complete correctness or efficiency.
> 
> The result of this patchset is the following: the attribute
> kconfig_symbol is added but only for some modules, namely for
> those for which the module name corresponds to the source file
> name of the driver. This has been observed by the fact that
> there are more srcversion attributes than kconfig_symbol. This
> happens mostly because, in some cases, the driver name does not
> match the registered module name (more details in the the PATCH2
> commit message). Also, in file Module.ksymb some object names
> have more than one CONFIG_* symbol. This is because that object
> it may be a platform independent component that is linked to more
> than one driver. So, all CONFIGs in which is found appear as
> associated with this object. However, I'm guessing this doesn't
> happen for final individual modules.
> Currently, for the sake of the proof of concept, the first of
> the CONFIG_* options is considered.
> 
> Usage:
> First run 'make localmodconfig' in order to generate the .config
> file and Module.ksymb file with the associations. Then compile
> the kernel. In the machine booted with this kernel kconfig_symbol
> attributes should appear in /sys instances of the modules.

Thanks Cristina, it helps to explain the motivation. Can you help describe
that? In subsequent patch iterations please include that? I'll go review the
patches now!

  Luis