From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932297AbcHIQDG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Aug 2016 12:03:06 -0400
Received: from mx2.suse.de ([195.135.220.15]:46363 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932255AbcHIQDD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Aug 2016 12:03:03 -0400
Date: Tue, 9 Aug 2016 18:03:05 +0200
From: Joerg Roedel <jroedel@suse.de>
To: Thomas Garnier <thgarnie@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@suse.de>,
        Dave Young <dyoung@redhat.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Lv Zheng <lv.zheng@intel.com>, Baoquan He <bhe@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Mark Salter <msalter@redhat.com>,
        Aleksey Makarov <aleksey.makarov@linaro.org>,
        Kees Cook <keescook@chromium.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Fabian Frederick <fabf@skynet.be>, Toshi Kani <toshi.kani@hp.com>,
        Dan Williams <dan.j.williams@intel.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Kernel Hardening <kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH v1 1/2] x86/KASLR: Fix physical memory calculation on
 KASLR memory randomization
Message-ID: <20160809160305.GF30880@suse.de>
References: <1470681607-36883-1-git-send-email-thgarnie@google.com>
 <CAJcbSZFOMJkXNJX-eMCgyesp71+j+MZTteuS9gBUjpHL=u_sZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJcbSZFOMJkXNJX-eMCgyesp71+j+MZTteuS9gBUjpHL=u_sZA@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 09, 2016 at 09:00:04AM -0700, Thomas Garnier wrote:
> On Mon, Aug 8, 2016 at 11:40 AM, Thomas Garnier <thgarnie@google.com> wrote:
> > Initialize KASLR memory randomization after max_pfn is initialized. Also
> > ensure the size is rounded up. Could have create problems on machines
> > with more than 1Tb of memory on certain random addresses.
> >
> > Signed-off-by: Thomas Garnier <thgarnie@google.com>
> 
> I will send a new version of this PATCH soon. The test bot found
> places where virtual addresses were computed before PAGE_OFFSET was
> set. I will investigate that.

When you do that, please also add 'Fixes:' tags to your patches.

Thanks,

	Joerg